fix(react-swc): fix @vitejs/plugin-react-swc/preamble on build

[HcySunYang]

Description

Should ensure hmrDisabled is set to true during build, preventing React refresh runtime from being included in production bundles.

Otherwise:

error during build:
[vite]: Rollup failed to resolve import "/@react-refresh" from "@vitejs/plugin-react-swc/preamble".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`

[hi-ogawa]

I think this is a bug fix? Probably I missed that hmrDisabled = true happens with apply: 'serve' currently

vite-plugin-react/packages/plugin-react-swc/src/index.ts

Lines 119 to 136 in 99d0fc4

	name: 'vite:react-swc',
	apply: 'serve',
	config: () => ({
	esbuild: false,
	// NOTE: oxc option only exists in rolldown-vite
	oxc: false,
	optimizeDeps: {
	include: [`${options.jsxImportSource}/jsx-dev-runtime`],
	...('rolldownVersion' in vite
	? {
	rollupOptions: { transform: { jsx: { runtime: 'automatic' } } },
	}
	: { esbuildOptions: { jsx: 'automatic' } }),
	},
	}),
	configResolved(config) {
	viteCacheRoot = config.cacheDir
	if (config.server.hmr === false) hmrDisabled = true

I think it should be safe to flip the logic by starting from let hmrDisabled = true and then check config.server.hmr !== false, which becomes closer to @vitejs/plugin-react

vite-plugin-react/packages/plugin-react/src/index.ts

Line 120 in 99d0fc4

let skipFastRefresh = true

[ArnaudBarre]

Yeah I would prefer to avoid an extra plugin which makes thinks harder to track

[HcySunYang]

Have updated the implementation

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-react@962

npm i https://pkg.pr.new/@vitejs/plugin-react-oxc@962

npm i https://pkg.pr.new/@vitejs/plugin-rsc@962

npm i https://pkg.pr.new/@vitejs/plugin-react-swc@962

commit: 8c65950

[hi-ogawa]

Thanks!