Skip to content

adds Related Origin Requests #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Jul 17, 2024
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
0522807
initial text
timcappalli Mar 12, 2024
d48a18c
remaining draft text
timcappalli Mar 12, 2024
2a18351
s/webauthn-origins/webauthn
timcappalli Mar 13, 2024
689647c
MUST support 5 origin labels
timcappalli Mar 13, 2024
3aad054
s/member/property, s/list/array
timcappalli Mar 13, 2024
5187e72
use [=continue=]
timcappalli Mar 26, 2024
881ac8f
collapse multiple steps into one
timcappalli Mar 26, 2024
9062a15
s/vanity/alternative
timcappalli Mar 26, 2024
2315db8
capitalization
timcappalli Mar 26, 2024
8ea0303
s/relatedOriginRequests/relatedOrigins
timcappalli Mar 26, 2024
28a2b0f
attempt at using a procedure
timcappalli Mar 26, 2024
b51bd16
s/must/MUST
timcappalli Mar 26, 2024
a21babf
remove break
timcappalli Apr 29, 2024
7466f32
remove break for create
timcappalli Apr 29, 2024
e7d0c7c
s/originLabelsSeen/labelsSeen and set def
timcappalli Apr 29, 2024
b3bf34c
word order
timcappalli Apr 29, 2024
bdba742
Validation step optimization
timcappalli Apr 29, 2024
de25c37
use macros for true and false
timcappalli Apr 29, 2024
71e4e80
add period
timcappalli Jun 12, 2024
26d350c
text tweak
timcappalli Jun 12, 2024
a2ac319
clean up well-known JSON definition
timcappalli Jun 14, 2024
b120220
s/origin labels/labels
timcappalli Jun 14, 2024
bcec7fa
s/rpIdRequested/callerOrigin
timcappalli Jun 14, 2024
3ba2ff3
move set contains label check after origin match check
timcappalli Jun 14, 2024
a108a2c
add RP guidance around adding all origins with the same origin label …
timcappalli Jun 14, 2024
c0c40d1
remove check for label in labelsSeen, not necessary
timcappalli Jun 14, 2024
ebf03eb
fix indents
timcappalli Jun 14, 2024
e4f24d9
update RWO algo to support additional origins with the same label
timcappalli Jun 26, 2024
2e9bdcf
remove consideration text for RPs about RWO well-known ordering
timcappalli Jun 26, 2024
2462fd8
Emil's feedback
timcappalli Jul 17, 2024
9da2c4b
procedure dfn
timcappalli Jul 17, 2024
017a5e3
Editorial tweaks
timcappalli Jul 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
s/originLabelsSeen/labelsSeen and set def
Co-authored-by: Emil Lundberg <[email protected]>
  • Loading branch information
timcappalli and emlun authored Apr 29, 2024
commit e7d0c7cdb39dbc5c76c971e468e3da8d25fd3da3
2 changes: 1 addition & 1 deletion index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -4115,7 +4115,7 @@ To validate the calling origin is an authorized related origin for a given cerem
1. If the fetch fails, the response does not have a content type of `application/json`, or does not have a status code (after following redirects) of 200, then throw a "{{SecurityError}}" {{DOMException}}.
1. If the body of the resource is not a valid JSON object, then throw a "{{SecurityError}}" {{DOMException}}.
1. If the value of the |origins| property of the JSON object is missing, or is not an array of strings, then throw a "{{SecurityError}}" {{DOMException}}.
1. Let |originLabelsSeen| be an empty set.
1. Let |labelsSeen| be a new empty [=set=].
1. [=set/For each=] string in |origins|:
1. Let |url| be the result of parsing the string as a URL. If that fails, [=continue=].
1. Let |domain| be the [=effective domain=] of |url|. If that is null, [=continue=].
Expand Down