Skip to content

feat: added external_proxy_header option #886

Closed
hdhog wants to merge 4 commits into
warp-tech:mainfrom
hdhog:main
Closed

feat: added external_proxy_header option #886
hdhog wants to merge 4 commits into
warp-tech:mainfrom
hdhog:main

Conversation

@hdhog

@hdhog hdhog commented Sep 4, 2023

Copy link
Copy Markdown

#885 added new options external_proxy_header

defaults

external_proxy_header:
  host: "host"
  proto: "x-forwarded-proto"

@Eugeny

Eugeny commented Sep 4, 2023

Copy link
Copy Markdown
Member

Thank you for the PR! Is your plan to use host: x-forwarded-host in your configuration? In this case, do you think it would make more sense to simply add a trust_proxy_headers config option and allow fallback from x-forwarded-host to the normal host so that it works both "internally" and "externally"?

@lanrat lanrat mentioned this pull request Oct 26, 2023
@lanrat

lanrat commented Oct 26, 2023

Copy link
Copy Markdown

@Eugeny Is there any chance you could merge this or another fix for the host header behind a reverse proxy?

Currently, Warpgate is broken when behind a reverse proxy due to it always adding its internal listen url to the callback.

@Skyler84

Skyler84 commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

I've had Warpgate working fine behind a reverse proxy (Traefik), as long as the external_host field is set warpgate redirects correctly!
I do like the suggestion of trust_proxy_headers so that Warpgate would pick up on those if present, otherwise fallback to Host!

@Eugeny

Eugeny commented Jan 24, 2024

Copy link
Copy Markdown
Member

Closing in favour of #907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants