Cleanup transfers and codebase imports#314
Merged
Merged
Conversation
- replaced local imports with global imports using $src - moved FileTable files into its own directory - moved WithMenuAccelerators into a new hoc directory - share Icons constant with Cypress test files
Also renamed batch to transfer everywhere.
Still need to plug other type of copies to new AppState.copy() method. Also need to do some heavy copy error testing.
Also fixed openTransferedFile typo
When attempting to drop elements in a filetable, only a little outline indicated if the target was valid. This PR adds a bigger overlay with an icon that clearly indicates the target's validity. The Loader component was renamed to Overlay and made generic so it can be reused for the drop target.
…ed getters We had to make this change because toJS ignores computed properties. This explains why download progress bar was still displayed, even though the transfer was done. This commit also fixes the badge which did not appear because some actions done inside async functions were not wrapped into runInAction calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up transfers:
state/transferState+state/transferListStatebatchtotransfer$srcI also did some visual tweaks: drop target will now show a nice overlay show target's validity.