runfix: conversation component infinite rerender - #14314
Merged
Merged
Conversation
atomrc
approved these changes
Dec 13, 2022
przemvs
approved these changes
Dec 13, 2022
tlebon
approved these changes
Dec 13, 2022
V-Gira
approved these changes
Dec 13, 2022
PatrykBuniX
enabled auto-merge (squash)
December 13, 2022 14:42
atomrc
disabled auto-merge
December 13, 2022 14:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for infinite rerender bug in conversation component.
The reason behind the issue is the fact that react is calling ref callback function every time we change it's reference.
Docs: https://reactjs.org/docs/refs-and-the-dom.html#caveats-with-callback-refs