Repository navigation
Fix builds against reduced wolfSSL configs - #64
Open
aidangarske wants to merge 14 commits into
Open
aidangarske wants to merge 14 commits into
aidangarske wants to merge 14 commits into
Conversation
aidangarske
requested review from
wolfSSL-Fenrir-bot
and removed request for
wolfSSL-Fenrir-bot
October 14, 2026 20:24
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #64
Scan targets checked: go-wolfssl-src, go-wolfssl-bugs
Coverage: 7 of 11 in-scope changed file(s) opened by the reviewer; not opened: aes.go, fips.go, wolftls/tls_test.go, wolfx509/certgen_wolfcrypt.go
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-7862- 67cf857 - The NO_SHA256 stub block now defines WC_SHA256 so builds with --disable-sha256 compile.F-7873- 9b9b72f - The certificate setup helper now reports whether WOLFSSL_CERT_SETUP_CB exists, and the handshake fails when GetCertificate cannot be installed instead of skipping it.F-7882- f15953b - The wolfSSL_X509_free stub is now compiled only when libwolfssl omits that function, so it no longer replaces the real free and leaks.F-7886- 4d211ab - wolfSSL_UseSNI and wolfSSL_CTX_UseSNI now have stubs returning -174 when wolfSSL is built without HAVE_SNI.F-9657- b84e94d - The wolftls SNI callback helper is stubbed without HAVE_SNI, and ctxSetSNICallback now returns an error instead of doing nothing.F-13584- 7e70ac3 - The PKCS8 and PEM to DER wrappers are now stubbed on their own guards, HAVE_PKCS8 and WOLFSSL_PEM_TO_DER, so no-PEM and no-PKCS8 builds link.F-9626- f8198c3 - go.mod and go.sum now pin golang.org/x/term so the examples build with -mod=readonly.F-9643- 4c8ab90 - The RSA-PSS stub prototypes now take enum wc_HashType, matching the real wolfCrypt API.F-6393- 19cc6c9 - The NO_AES stub block now defines GCM_NONCE_MID_SZ.F-7871- 6785e67 - The fips.go cgo preamble now includes stdio.h for the FIPS callback printf calls.F-14888- 4c4b0ec - wolftls/version.go now applies MinVersion with the native wolfSSL_CTX_SetMinVersion when OPENSSL_EXTRA is absent, and a MaxVersion below the build ceiling returns a clear error there instead of -174.F-7867- e1d5545 - wolfx509 now has an #error guard naming WOLFSSL_CERT_GEN, WOLFSSL_CERT_EXT and WOLFSSL_ALT_NAMES, and the README no longer claims vanilla builds work.CI- 8e3f217 - The build workflow now runs the root package tests and the wolftls version and GetCertificate fallback tests in the default config, and builds and links the Go packages against two reduced wolfSSL configs (no SNI or AES, and no SHA-256, RSA, PKCS8 or PEM) after checking their defines; the job timeout goes from 14 to 20 minutes.