Repository navigation
Conversation
test_transport.c was the only source whose header opened with a title line and ended with the old "51 Franklin Street" postal address. Every other file uses the "If not, see <http://www.gnu.org/licenses/>" form. Use the same block so the header matches the license_replace template and a gplv3 run leaves the file alone.
The SBOM recorded the license through a hard-coded SBOM_LICENSE_OVERRIDE / WOLFCERT_SBOM_LICENSE of GPL-3.0-or-later, because LICENSE is the full GPLv3 text and gen-sbom cannot tell -only from -or-later from it. A commercial bundle made by license_replace kept that override, so its SBOM still declared GPL. Add a LICENSING statement, as wolfSSL and wolfHSM have, and point the autoconf, CMake and Zephyr SBOM targets at it. gen-sbom detects GPL-3.0-or-later from its wording, so the generated SBOMs are unchanged. license_replace overwrites LICENSING for commercial bundles, whose SBOM then records NOASSERTION unless the licensee passes SBOM_LICENSE_OVERRIDE / -DWOLFCERT_SBOM_LICENSE, the same as wolfSSL. WOLFCERT_SBOM_LICENSE now defaults to empty and is only passed when set.
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently implement file-based license detection across build integrations, with no unresolved blocking issues.
No open issues 🎉
What changed in this PR
Updates wolfCert’s SBOM generation to derive licensing from LICENSING, allowing commercial bundles to replace the statement without retaining a hard-coded GPL declaration.
Changes:
- Adds and distributes
LICENSING. - Updates all SBOM build integrations while preserving explicit overrides.
- Refreshes documentation and standardizes a test file’s license comment.
| File | Description |
|---|---|
| zephyr/CMakeLists.txt | Reads LICENSING; makes the override optional. |
| tests/unit/test_transport.c | Standardizes the license comment only. |
| Makefile.am | Distributes and uses LICENSING for SBOM generation. |
| LICENSING | Adds the GPL-or-commercial licensing statement. |
| docs/SBOM.md | Documents file-based detection and updates the example. |
| CMakeLists.txt | Reads LICENSING; removes the default GPL override. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SBOM license was hard-coded to
GPL-3.0-or-laterthroughSBOM_LICENSE_OVERRIDE(autoconf) andWOLFCERT_SBOM_LICENSE(CMake, Zephyr), becauseLICENSEis the full GPLv3 text and gen-sbom cannot tell-onlyfrom-or-laterfrom it. A commercial bundle made withlicense_replacekept that override, so its SBOM still declared GPL.Changes
LICENSING: new licensing statement in the wording wolfHSM uses ("GPLv3 (or at your option any later version) or a standard commercial license"), added toEXTRA_DIST.LICENSINGas the license file and drop the hard-coded override. gen-sbom detectsGPL-3.0-or-laterfrom the wording, so the generated SBOMs are unchanged.license_replaceswapsLICENSINGfor the commercial text, so the SBOM recordsNOASSERTIONunless the licensee passesSBOM_LICENSE_OVERRIDE/-DWOLFCERT_SBOM_LICENSE. This matches wolfSSL.WOLFCERT_SBOM_LICENSEnow defaults to empty and is only passed when set. A CMake build directory configured before this change keeps the old cached value until it is reconfigured with-UWOLFCERT_SBOM_LICENSEor recreated.tests/unit/test_transport.c: replaced the one non-standard license header (title line, old "51 Franklin Street" ending) with the block every other file uses, so it matches thelicense_replacetemplate.Companion scripts PR: https://github.com/wolfSSL/scripts/pull/701 adds wolfCert to
license_replace.