Skip to content

Read the SBOM license from a LICENSING file - #60

Open
Frauschi wants to merge 2 commits into
wolfSSL:mainfrom
Frauschi:sbom-licensing
Open

Frauschi wants to merge 2 commits into
wolfSSL:mainfrom
Frauschi:sbom-licensing

Conversation

@Frauschi

Copy link
Copy Markdown
Member

The SBOM license was hard-coded to GPL-3.0-or-later through SBOM_LICENSE_OVERRIDE (autoconf) and WOLFCERT_SBOM_LICENSE (CMake, Zephyr), because LICENSE is the full GPLv3 text and gen-sbom cannot tell -only from -or-later from it. A commercial bundle made with license_replace kept that override, so its SBOM still declared GPL.

Changes

  • LICENSING: new licensing statement in the wording wolfHSM uses ("GPLv3 (or at your option any later version) or a standard commercial license"), added to EXTRA_DIST.
  • SBOM targets: autoconf, CMake and Zephyr pass LICENSING as the license file and drop the hard-coded override. gen-sbom detects GPL-3.0-or-later from the wording, so the generated SBOMs are unchanged.
  • Commercial bundles: license_replace swaps LICENSING for the commercial text, so the SBOM records NOASSERTION unless the licensee passes SBOM_LICENSE_OVERRIDE / -DWOLFCERT_SBOM_LICENSE. This matches wolfSSL.
  • WOLFCERT_SBOM_LICENSE now defaults to empty and is only passed when set. A CMake build directory configured before this change keeps the old cached value until it is reconfigured with -UWOLFCERT_SBOM_LICENSE or recreated.
  • tests/unit/test_transport.c: replaced the one non-standard license header (title line, old "51 Franklin Street" ending) with the block every other file uses, so it matches the license_replace template.

Companion scripts PR: https://github.com/wolfSSL/scripts/pull/701 adds wolfCert to license_replace.

test_transport.c was the only source whose header opened with a title
line and ended with the old "51 Franklin Street" postal address. Every
other file uses the "If not, see <http://www.gnu.org/licenses/>" form.
Use the same block so the header matches the license_replace template
and a gplv3 run leaves the file alone.
The SBOM recorded the license through a hard-coded
SBOM_LICENSE_OVERRIDE / WOLFCERT_SBOM_LICENSE of GPL-3.0-or-later,
because LICENSE is the full GPLv3 text and gen-sbom cannot tell -only
from -or-later from it. A commercial bundle made by license_replace
kept that override, so its SBOM still declared GPL.

Add a LICENSING statement, as wolfSSL and wolfHSM have, and point the
autoconf, CMake and Zephyr SBOM targets at it. gen-sbom detects
GPL-3.0-or-later from its wording, so the generated SBOMs are
unchanged. license_replace overwrites LICENSING for commercial bundles,
whose SBOM then records NOASSERTION unless the licensee passes
SBOM_LICENSE_OVERRIDE / -DWOLFCERT_SBOM_LICENSE, the same as wolfSSL.
WOLFCERT_SBOM_LICENSE now defaults to empty and is only passed when set.
@Frauschi Frauschi self-assigned this Oct 19, 2026
Copilot AI balanced review requested due to automatic review settings October 19, 2026 17:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes consistently implement file-based license detection across build integrations, with no unresolved blocking issues.

No open issues 🎉

What changed in this PR

Updates wolfCert’s SBOM generation to derive licensing from LICENSING, allowing commercial bundles to replace the statement without retaining a hard-coded GPL declaration.

Changes:

  • Adds and distributes LICENSING.
  • Updates all SBOM build integrations while preserving explicit overrides.
  • Refreshes documentation and standardizes a test file’s license comment.
File Description
zephyr/​CMakeLists.txt Reads LICENSING; makes the override optional.
tests/​unit/​test_transport.c Standardizes the license comment only.
Makefile.am Distributes and uses LICENSING for SBOM generation.
LICENSING Adds the GPL-or-commercial licensing statement.
docs/​SBOM.md Documents file-based detection and updates the example.
CMakeLists.txt Reads LICENSING; removes the default GPL override.

Review effort: Balanced

@Frauschi Frauschi assigned wolfSSL-Bot and unassigned Frauschi Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants