Skip to content

Correct AES CCM cipher state and results - #240

Closed
aidangarske wants to merge 4 commits into
wolfSSL:masterfrom
aidangarske:fenrir-fixes-ccm-cipher
Closed

aidangarske wants to merge 4 commits into
wolfSSL:masterfrom
aidangarske:fenrir-fixes-ccm-cipher

Conversation

@aidangarske

Copy link
Copy Markdown
Member

F-6452 - 7fc367c - AES-CCM failures now produce the correct diagnostic.

F-11321 - c709fb3 - AES-CCM now uses the standard default tag size.

F-10136 - c9906e0 - Empty AES-CCM updates now report zero output.

F-13038 - 98fd5e7 - AES-CCM decryption now preserves its nonce.

@aidangarske aidangarske self-assigned this Oct 15, 2026
@aidangarske

Copy link
Copy Markdown
Member Author

jenkins retest this please

@aidangarske
aidangarske marked this pull request as ready for review October 15, 2026 22:39

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #240

Scan targets checked: wolfengine-src, wolfengine-bugs
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: test/test_aestag.c

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Review tier: Lite

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #240

Scan targets checked: wolfengine-src, wolfengine-bugs
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Lite

@wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot dismissed their stale review October 16, 2026 02:09

Fenrir's latest completed scan found no issues; clearing the prior automated change request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants