Repository navigation
20260904-linuxkm-misc - #11382
20260904-linuxkm-misc#11382
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11382
Scan targets checked: linuxkm-bugs, linuxkm-src, wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
|
2c52057 to
8864af4
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11382
Scan targets checked: linuxkm-src, linuxkm-bugs, wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11382
Scan targets checked: linuxkm-src, linuxkm-bugs, wolfssl-src, wolfssl-bugs
Unchanged since last review (not re-run): wolfcrypt-src, wolfcrypt-bugs
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
* reduce WC_LINUXKM_MAX_NS_WITHOUT_YIELD from 1 second to 25 ms for better kernel citizenship.
* add WC_DEBUG_FORCE_KERNEL_SETTINGS for inhibiting #errors on unsupported configurations.
* add __extension__ annotation to macros that need it.
* add wc_svr_disallowed_count_reset() and wc_svr_disallowed_count_current().
* fix CAN_SAVE_VECTOR_REGISTERS() to honor DEBUG_VECTOR_REGISTER_ACCESS_ALWAYS_{ON,OFF}.
* add WC_RELAX_LONG_LOOP() to DEBUG_VECTOR_REGISTER_ACCESS_ALWAYS_OFF variant of SAVE_VECTOR_REGISTERS2().
* allow for fully user-supplied SAVE_VECTOR_REGISTERS() and friends.
* add WOLFSSL_DEBUG_TRACE_ERROR_CODES coverage for all system error codes used by module_hooks.c and its includes. * implement double-run wolfCrypt_IntegrityTest_fips() and wc_RunAllCast_fips() in WC_C_DYNAMIC_FALLBACK configurations, once with acceleration on (leveraging fallback instrumentation to fail the module if any fallbacks occur), and once with it forced off using DISABLE_VECTOR_REGISTERS().
…DEBUG_VECTOR_REGISTER_ACCESS_ALWAYS_ON, inhibit DISABLE_VECTOR_REGISTERS() exercises and auditing of wc_svr_disallowed_count_current().
…run_code_audit_accel and /sys/module/libwolfssl/FIPS_optest_run_code_audit_c.
… USE_INTEL_SPEEDUP, don't expect wc_svr_disallowed_count_current() to increase for wolfCrypt_IntegrityTest_fips() (no AES in it).
…PI coexistence: in FIPS_optest_trig_handler(), implement assiduous (atomic-based) mutual exclusion with LKCAPI registration.
…, not wc_HmacUpdate_fips(), for compatibility with dev-no-post.
…ith a runtime check that kernel fips_enabled is zero.
* add libwolfssl_inited flag variable and use it for proper error-path cleanup; * call wc_linuxkm_allocate_svr_states() and wc_linuxkm_free_svr_states() explicitly in FIPS builds (avoid atomic-context synchronous call to wc_linuxkm_allocate_svr_states() via fipEntry()); * add missing WOLFSSL_FIPS_DEV_NO_POST gates; * in wc_lkm_LockMutex(), return BUSY_E immediately if in_nmi().
…batching several chunks within a single SAVE_VECTOR_REGISTERS2() bracket (entails adding WALK_ATOMIC to calls that affect walk dynamics during the locked batches).
…ERROR_CODES_PER_FILE and WOLFSSL_DEBUG_TRACE_ERROR_CODES_THIS_FILE (file-scoped code traces).
…G_PREEMPT_RT kernels.
…WOLFSSL_ATOMIC_LOAD() and WOLFSSL_ATOMIC_STORE(), use __ATOMIC_SEQ_CST rather than __ATOMIC_CONSUME/__ATOMIC_RELEASE, for consistency with semantics of the primary C11 bindings to atomic_load() and atomic_store().
…rly, and add WC_LINUXKM_HAVE_MY_KALLSYMS_LOOKUP_NAME.
…S_optest_trig_audit_c_attr to use distinct handlers that pass distinct mode arguments to a multi-personality FIPS_optest_trig_common(), properly implementing the SVR-auditing variants of the FIPS_optest_run_code sysfs node.
…ECTOR_REGISTER_ACCESS_ALWAYS_{OFF,ON} settings.
* always call wolfCrypt_Init() directly, even in TLS builds, to assure mutex-free scheduler context during allocations; * convert sysfs nodes from struct kobj_attribute to struct module_attribute, matching the module_sysfs_ops dispatch on THIS_MODULE->mkobj.kobj, for compatibility with CONFIG_CFI_CLANG (kCFI) kernels.
…ase batch opening, leaving just the existing batch opening inside the main crypt loop, to avoid unnecessary atomic-context allocations in the preamble; linuxkm/module_hooks.c: * add wc_linuxkm_deinstall(), which idempotently deregisters all algorithms and sysfs nodes, and call it from libwolfssl_cleanup() and wolfssl_exit(); * refactor in_optest atomic flag (local to FIPS_optest_trig_common()) to file-scoped in_fips_test, and use it as a mutex for both FIPS_rerun_self_test_handler() and FIPS_optest_trig_common().
… exclusion gate for test clauses that depends on new fixes (implicit public key rederivation on import etc.). add missing && !defined(NO_TLS) gate to test_wolfSSL_certs_clear().
d901f73 to
1c288d5
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11382
Scan targets checked: linuxkm-src, linuxkm-bugs, wolfcrypt-src, wolfcrypt-bugs
Unchanged since last review (not re-run): wolfssl-src, wolfssl-bugs
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
…IG_PREEMPT_RT (walk/map paths must run preemptible with that config).
…for correct error-path unwind, and use it in wc_HmacFree() for all deallocation. Fixes F-8163 -- "wc_HmacCopy shallow-copies the cached inner and outer hash contexts".
1c288d5 to
e5c3683
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11382
Scan targets checked: linuxkm-src, linuxkm-bugs
Unchanged since last review (not re-run): wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Fenrir's latest completed scan found no issues; clearing the prior automated change request.
|
Jenkins: retest this please |
|
The Jenkins failure is on the new FIPS v6 tests, on sanitizing optest, and is presumptively nothing to do with this PR. FWIW this PR was tested here on FIPS v6, and has FIPS v6 fixes in it! |
|
retest this please |
linuxkm/linuxkm_wc_port.h:WC_LINUXKM_MAX_NS_WITHOUT_YIELDfrom 1 second to 25 ms for better kernel citizenship.WC_DEBUG_FORCE_KERNEL_SETTINGSfor inhibiting#errorson unsupported configurations.__extension__annotation to macros that need it.wc_svr_disallowed_count_reset()andwc_svr_disallowed_count_current().CAN_SAVE_VECTOR_REGISTERS()to honorDEBUG_VECTOR_REGISTER_ACCESS_ALWAYS_{ON,OFF}.WC_RELAX_LONG_LOOP()toDEBUG_VECTOR_REGISTER_ACCESS_ALWAYS_OFFvariant ofSAVE_VECTOR_REGISTERS2().SAVE_VECTOR_REGISTERS()and friends.linuxkm/module_hooks.c:WOLFSSL_DEBUG_TRACE_ERROR_CODEScoverage for all system error codes used bymodule_hooks.cand its includes.wolfCrypt_IntegrityTest_fips()andwc_RunAllCast_fips()inWC_C_DYNAMIC_FALLBACKconfigurations, once with acceleration on (leveraging fallback instrumentation to fail the module if any fallbacks occur), and once with it forced off usingDISABLE_VECTOR_REGISTERS().linuxkm/module_hooks.c: whenDEBUG_VECTOR_REGISTER_ACCESS_FUZZINGorDEBUG_VECTOR_REGISTER_ACCESS_ALWAYS_ON, inhibitDISABLE_VECTOR_REGISTERS()exercises and auditing ofwc_svr_disallowed_count_current().linuxkm/module_hooks.c: implement/sys/module/libwolfssl/FIPS_optest_run_code_audit_acceland/sys/module/libwolfssl/FIPS_optest_run_code_audit_c.linuxkm/module_hooks.c: inwolfssl_init(), whenWOLFSSL_AESNIbut notUSE_INTEL_SPEEDUP, don't expectwc_svr_disallowed_count_current()to increase forwolfCrypt_IntegrityTest_fips()(no AES in it).linuxkm/module_hooks.candwolfcrypt/src/rng_bank.c: fixes for external review ofFIPS_OPTEST/LKCAPI coexistence and affinity lock error handling.in
FIPS_optest_trig_handler(), implement assiduous (atomic-based) mutual exclusion with LKCAPI registration.in
wc_rng_bank_checkout(), propagateINTERRUPTED_Efrombank->affinity_lock_cbrather than swallowing it -- caller-requested interruption must abort checkout, consistent with theWC_CHECK_FOR_INTR_SIGNALS()handling in the same loop; other affinity lock errors continue to be tolerated (affinity is advisory).linuxkm/linuxkm-fips-hash.c: inhmac_update_cb(), usewc_HmacUpdate(), notwc_HmacUpdate_fips(), for compatibility withdev-no-post.linuxkm/lkcapi_glue.c: tolerate !HAVE_FIPSwithCONFIG_CRYPTO_FIPS, with a runtime check that kernelfips_enabledis zero.linuxkm/module_hooks.c:add
libwolfssl_initedflag variable and use it for proper error-path cleanup;call
wc_linuxkm_allocate_svr_states()andwc_linuxkm_free_svr_states()explicitly in FIPS builds (avoid atomic-context synchronous call towc_linuxkm_allocate_svr_states()viafipEntry());add missing
WOLFSSL_FIPS_DEV_NO_POSTgates;in
wc_lkm_LockMutex(), returnBUSY_Eimmediately ifin_nmi().tested with