CA-309302 Handle some less common cases in direct_copy#88
Merged
Conversation
edwintorok
reviewed
Feb 4, 2019
|
|
||
| pfd.fd = fd; | ||
| pfd.events = event; | ||
| return poll(&pfd, 1, -1); |
Member
There was a problem hiding this comment.
Since we're fixing EINTR below, what if poll got an EINTR?
Author
There was a problem hiding this comment.
Fair point. Can just continue in that case.
The copy wrapper might be handed non-blocking filedescriptors, which would cause problems. The caller tries not do do that, but it is worth being robust against it anyway. Signed-off-by: Tim Smith <tim.smith@citrix.com>
f1214fc to
12ef1dc
Compare
edwintorok
approved these changes
Feb 5, 2019
Member
There was a problem hiding this comment.
Although I prefer having less C code, the EINTR handling here is useful, and I can't spot anything else wrong with the code.
In the future we could investigate whether Lwt_unix.readv/writev could be used instead with Bigarray slices, that should allow us to transfer more than 64k/syscall from OCaml without going through custom C stubs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The copy wrapper might be handed non-blocking filedescriptors, which
would cause problems. The caller tries not do do that, but it is worth
being robust against it anyway.
Signed-off-by: Tim Smith tim.smith@citrix.com