Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Allow PHPUnit ^7.0 - #60

Merged
Xerkus merged 2 commits into
zendframework:masterfrom
Slamdunk:patch-1
Apr 6, 2018
Merged

Allow PHPUnit ^7.0#60
Xerkus merged 2 commits into
zendframework:masterfrom
Slamdunk:patch-1

Conversation

@Slamdunk

@Slamdunk Slamdunk commented Mar 3, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@michalbundyra

Copy link
Copy Markdown
Member

Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. Run update to update them.

After changing composer.json file composer.lock should be updated as well.

@Slamdunk

Slamdunk commented Mar 5, 2018

Copy link
Copy Markdown
Contributor Author

After changing composer.json file composer.lock should be updated as well.

Of course, but how?
I mean, we all know the command composer update --lock but thisis not the case.
The lock file here is present to test a particular set of depencencies that are neither the lowest nor the latest. The fact is that I don't know how to rebuild it, or putin another way, I don't know the exact envirnoment on how the lock file should be updated into.

@michalbundyra

Copy link
Copy Markdown
Member

Of course, but how?

Basically build should work with any lock file - generated on any env but and builds should check set of different configuration - with different dependencies. I think you can use either

$ composer update --lock

or:

$ composer update nothing

and it will just update the hash in composer.lock. And it's enough.

@Slamdunk

Slamdunk commented Mar 5, 2018

Copy link
Copy Markdown
Contributor Author

I repeat what I saidin the previous comment: of course composer update --lock updates the lock file hash, but I think it's useless because it doesn't address the purpose of the lock file.

Btw, I've updated it.

@Ocramius

Ocramius commented Mar 5, 2018

Copy link
Copy Markdown
Member

@Slamdunk the only reason to do that is to keep composer.lock in sync, even if dependencies are still older than the latest ones.

@MatyCZ

MatyCZ commented Mar 19, 2018

Copy link
Copy Markdown

Any ETA to merge?

@Xerkus
Xerkus merged commit 3e0ebcc into zendframework:master Apr 6, 2018
Xerkus added a commit that referenced this pull request Apr 6, 2018
Xerkus added a commit that referenced this pull request Apr 6, 2018
Xerkus added a commit that referenced this pull request Apr 6, 2018
@Xerkus Xerkus added this to the 3.1.2 milestone Apr 6, 2018
@Slamdunk
Slamdunk deleted the patch-1 branch April 6, 2018 09:36
@Xerkus

Xerkus commented Apr 6, 2018

Copy link
Copy Markdown
Member

@Slamdunk thank you

@Xerkus Xerkus modified the milestones: 3.1.2, 3.2.0 Apr 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants