Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

Template updates #5

Merged
merged 7 commits into from
Sep 21, 2017
Merged

Template updates #5

merged 7 commits into from
Sep 21, 2017

Conversation

michalbundyra
Copy link
Member

  • added slack and forum links (footer)
  • removed IRC link
  • updated all links to https
  • changed logo to SVG image
  • updated styles to match current styles from zf-mkdocs-theme (generated there without prism)
  • updated to latest version of Bootstrap (3.3.7) and FontAwesome (4.7.0) - served from CDN
  • removed all unused resources: js, css, fonts

@michalbundyra
Copy link
Member Author

@froschdesign can you have a look, please?

@froschdesign
Copy link
Member

@webimpress
I would prefer to use MkDocs for this repository too. No duplicates of templates and all other files like the logo.
I think it should work.

@michalbundyra
Copy link
Member Author

@froschdesign

I would prefer to use MkDocs for this repository too.

Yeah, me too, but how to do that? There is no gh-pages branch so we need to have here final html file.

@froschdesign
Copy link
Member

@weierophinney must add this branch.

@michalbundyra
Copy link
Member Author

@froschdesign I can see couple issues with it:

  • homepage is different - we don't have "components" and "search" buttons on top nav (and in template is not possible to disable them)
  • on homepage we are not using any JS and we don't need prismjs, so compiled css can be lower here
  • in other components we are using files from this repository - mkdocs/js/search.js and mkdocs/js/require.js, if we create gh-pages branch then we have to move these files there as well, so we can't use normal build process (from theme repo).

In general it will be possible but still requires some changes in template, creating gh-pages branch etc. I would stick with this solution for now, till you push the new template 😍

@froschdesign
Copy link
Member

@webimpress
All these points are correct and I think we should merge your changes the fix the current problems. We can simplify this repository with the next steps.

/cc @weierophinney

@weierophinney weierophinney merged commit fdba737 into zendframework:master Sep 21, 2017
weierophinney added a commit that referenced this pull request Sep 21, 2017
weierophinney added a commit that referenced this pull request Sep 21, 2017
@weierophinney
Copy link
Member

Thanks, @webimpress; looks good!

@michalbundyra michalbundyra deleted the updates branch September 21, 2017 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants