We were recently looking to get Crop API module updated ahead of transitioning to Drupal 9, but found a rather strange issue happening.
On 8.x-1.5, there is an 8003 update hook
https://git.drupalcode.org/project/crop/-/blob/8.x-1.5/crop.install

That 8003 update hook is not present on 8.x-2.0
https://git.drupalcode.org/project/crop/-/blob/8.x-2.0/crop.install

But looks like the code from 8003 is now in 8004, but missing an 8003.

8003 is also missing on 8.x-2.1
https://git.drupalcode.org/project/crop/-/blob/8.x-2.1/crop.install

I would recommend just for consistency purposes, adding in that 8003, even if it's doing the same logic as 8004.

We had been using this patch (not sure how far back, but it's still in the codebase today and we're on 8.x-2.0, but working to update to 8.x-2.1)
https://www.drupal.org/node/2937337

I just thought it was really strange, but I think the main thing is to make sure that the module is indeed uninstalled either from 8003 or 8004 (depending on your version and if and when it was patched), but seeing a missing update hook number is strange and can lead to confusion.

Comments

joshua.boltz created an issue.