Part of meta issue #1805996: [META] Views in Drupal Core. Work on this issue is done in the VDC sandbox:

git clone --recursive --branch vdc http://git.drupal.org/sandbox/tim.plunkett/1799554.git vdc

Problem/Motivation

  • In order to provide default listings for users, the standard install profile should include Views.
  • To allow users to easily discover how to customize their site listings, the standard install profile should also include Views UI.

Proposed resolution

  • Add Views and Views UI to the standard install profile in the VDC sandbox.

Remaining tasks

  • TBD

User interface changes

  • TBD

API changes

  • TBD

Comments

xjm’s picture

Issue tags: +VDC

We'll also need to add config, as seen in #1786990-13: [Module]Bundle is registered too late in WebTestBase::setUp(). Weird that something doesn't already require it.

xjm’s picture

Priority: Normal » Major
Status: Postponed » Active

This is unblocked now!

xjm’s picture

Assigned: Unassigned » xjm

Let's see if I can do this. :)

tim.plunkett’s picture

Assigned: xjm » tim.plunkett
StatusFileSize
new371 bytes

I already tested this in the patch test issue, but it's just this + #1810378: Remove unneeded dependency on config.module
Since this is part of the core move, I'm going to roll it into my sandbox rebuilding steps, by amending it into http://drupalcode.org/sandbox/tim.plunkett/1799554.git/commitdiff/1342dfe when the time comes.
This is just a placeholder issue to remind me :)

tim.plunkett’s picture

Assigned: tim.plunkett » Unassigned
Status: Active » Fixed
xjm’s picture

LOL yay.

tim.plunkett’s picture

Status: Fixed » Active

So I think we're actually still blocked on the nastier bug.

#1783692: Test the bundle manager to show the fail on update.php
#1708692: Bundle services aren't available in the request that enables the module

exception 'Symfony\Component\DependencyInjection\Exception\InvalidArgumentException' with message 'The service definition "plugin.manager.views.display" does not exist.' in /var/lib/drupaltestbot/sites/default/files/checkout/core/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/ContainerBuilder.php:690
Stack trace:
#0 /var/lib/drupaltestbot/sites/default/files/checkout/core/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/ContainerBuilder.php(338): Symfony\Component\DependencyInjection\ContainerBuilder->getDefinition('plugin.manager....')
#1 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/views/views.module(1297): Symfony\Component\DependencyInjection\ContainerBuilder->get('plugin.manager....')
#2 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/views/lib/Drupal/views/ViewExecutable.php(579): views_get_plugin('display', 'default')
#3 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/views/lib/Drupal/views/ViewStorage.php(160): Drupal\views\ViewExecutable->initDisplay()
#4 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/views/views.module(660): Drupal\views\ViewStorage->initDisplay()
#5 [internal function]: views_block_info()
#6 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/module.inc(957): call_user_func_array('views_block_inf...', Array)
#7 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/block/block.module(424): module_invoke('views', 'block_info')
#8 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/block/block.module(963): _block_rehash('bartik')
#9 [internal function]: block_rebuild()
#10 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/module.inc(981): call_user_func_array('block_rebuild', Array)
#11 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/common.inc(6848): module_invoke_all('rebuild')
#12 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/install.core.inc(1706): drupal_flush_all_caches()
#13 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/batch.inc(427): _install_profile_modules_finished(true, Array, Array, '0 sec')
#14 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/batch.inc(329): _batch_finished()
#15 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/form.inc(4938): _batch_process()
#16 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/install.core.inc(533): batch_process('core/install.ph...', 'http://drupalte...')
#17 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/install.core.inc(429): install_run_task(Array, Array)
#18 /var/lib/drupaltestbot/sites/default/files/checkout/core/includes/install.core.inc(85): install_run_tasks(Array)
#19 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/simpletest/lib/Drupal/simpletest/WebTestBase.php(686): install_drupal(Array)
#20 /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/simpletest/lib/Drupal/simpletest/TestBase.php(629): Drupal\simpletest\WebTestBase->setUp()
#21 /var/lib/drupaltestbot/sites/default/files/checkout/core/scripts/run-tests.sh(381): Drupal\simpletest\TestBase->run()
#22 /var/lib/drupaltestbot/sites/default/files/checkout/core/scripts/run-tests.sh(22): simpletest_script_run_one_test('515', 'Drupal\user\Tes...')
#23 {main}FATAL Drupal\user\Tests\UserCancelTest: test runner returned a non-zero error code (1).
tim.plunkett’s picture

xjm’s picture

Project: VDC » Drupal core
Version: » 8.x-dev
Component: Code » views.module
tim.plunkett’s picture

Status: Postponed » Needs review
StatusFileSize
new5.22 KB
tim.plunkett’s picture

StatusFileSize
new371 bytes

That went in!

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Oh yes!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Great. I consider this clean-up after the initial feature, and only didn't go in at that time because we were blocked on critical bugs. Those have been resolved, so now it makes sense to put this in.

Committed and pushed to 8.x. Thanks!!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.