The test block appears in the custom category.
Other
DisplayBlockTest.php
102
Drupal\block\Tests\Views\DisplayBlockTest->testBlockCategory()	


The second cloned test block appears in the custom category.
Other
DisplayBlockTest.php
120
Drupal\block\Tests\Views\DisplayBlockTest->testBlockCategory()
CommentFileSizeAuthor
#15 drupal-2097537-15.patch4.78 KBolli
#15 interdiff.txt1.65 KBolli
#12 2097537-12-random-fail.patch816 bytesolli
#12 2097537-12-random-pass.patch3.6 KBolli
#12 drupal-2097537-12.patch3.13 KBolli
#4 block-2097537-4.patch897 bytestim.plunkett
#2 block-2097537-2.patch1.03 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +Random test failure

Tagging.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new block-2097537-2.patch1.03 KB

From form_builder():

  if (!isset($element['#id'])) {
    $element['#id'] = drupal_html_id('edit-' . implode('-', $element['#parents']));
  }

The implode is causes any leading or trailing hyphens to be stripped off before making the ID.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Priority: Normal » Critical
Status: Active » Needs review

Marking this critical because it just "broke" HEAD.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new block-2097537-4.patch897 bytes

Nevermind, that last assumption was completely wrong, and idk why I thought that. It's just that drupal_html_id() removes consecutive hyphens.

pwolanin’s picture

pwolanin commented

per IRC discussion - that's the wrong fix, instead move 'edit-' . inside the call to drupal_html_id($id)

pwolanin’s picture

pwolanin commented

cross-post - yes, #4 looks like the right fix.

pwolanin’s picture

pwolanin commented

I'm not sure that the String::checkPlain() is actually needed, but clearly it's already in the test.

pwolanin’s picture

pwolanin commented
Status: Needs review » Reviewed & tested by the community

RTBC (assuming the tests pass with the corrected logic).

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +VDC

Finally @tim.plunkett created the issue :P. RTBC +1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 34f638b and pushed to 8.x. Thanks!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Priority: Critical » Major
Status: Fixed » Active

Berdir found yet another random fail in the same place, but much less common...

olli’s picture

olli commented
Status: Active » Needs review
StatusFileSize
new drupal-2097537-12.patch3.13 KB
new 2097537-12-random-pass.patch3.6 KB
new 2097537-12-random-fail.patch816 bytes

Categories like "#random" are not visible on the block placement page.

Issue tags: +VDC, +Random test failure

The last submitted patch, drupal-2097537-12.patch, failed testing.

Status: Needs review » Needs work
Issue tags: -VDC, -Random test failure

The last submitted patch, drupal-2097537-12.patch, failed testing.

olli’s picture

olli commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.65 KB
new drupal-2097537-15.patch4.78 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Thanks... This has been awful :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Wow, great find!

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.