CommentFileSizeAuthor
testperf.help-HelpTest.patch987 bytessun

Comments

Status: Needs review » Needs work

The last submitted patch, testperf.help-HelpTest.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Fix test performance of Drupal\help\Tests\HelpTest » Remove Drupal\help\Tests\HelpTest
Related issues: +#2259311: Add automated tests for hook_help()

Turns out this "wildcard" test does not actually test anything useful.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

I don't see how this test is useless. It tests half of hook_help(), the part appearing on admin/help. It ensures that modules don't just use it to add help to their custom pages, but also provide the overview help.
The linked issue is about testing the help added to custom pages.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs work » Closed (works as designed)

I think this test was determined to have value over in #2368277: HelpTest should not use standard profile.