How it looks

1) Drupal\Tests\locale\Functional\LocaleTranslationUiTest::testStringTranslation
Behat\Mink\Exception\ExpectationException: An option "en" exists in select "edit-langcode", but it should not.

Examples:
https://www.drupal.org/pift-ci-job/708332
https://www.drupal.org/pift-ci-job/571364
https://www.drupal.org/pift-ci-job/712560

Proposed resolution

Replace random name generation, because it gives value containing 'en' with 1/250 (rough frequency).
or
Implement more stringent verification criteria, because check full page on 'en' it is a bit naive.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#20 interdiff-16-17-diff.txt729 bytesAnonymous (not verified)
#17 interdiff-16-17.txt729 bytesAnonymous (not verified)
#17 2891911-17.patch741 bytesAnonymous (not verified)
#16 interdiff-2-16.txt720 bytesAnonymous (not verified)
#16 2891911-16.patch742 bytesAnonymous (not verified)
#2 2891911-2.patch732 bytesAnonymous (not verified)
#2 2891911-2-test-only.patch761 bytesAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented

vaplas created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) commented
Related issues: +#2571183: Deprecate random() usage in tests to avoid random test failures
StatusFileSize
new 2891911-2-test-only.patch761 bytes
new 2891911-2.patch732 bytes
Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review

The last submitted patch, 2: 2891911-2-test-only.patch, failed testing. View results

xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Normal » Critical
Issue summary: View changes

Marking critical since it's a random test failure.

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes

Thank you, @xjm!

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Random test failure

#2 seems like a straightforward and correct fix to me. This issue is a classic case of a random string happening to match a different meaningful value, and simply providing a test value instead is better.

Thanks @vaplas!

  • catch committed e242bbd on 8.4.x 
    Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\Functional\...

  • catch committed 8384dc5 on 8.3.x 
    Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\Functional\...
catch’s picture

catch
he/him
Primary language English
commented

Committed e242bbd and pushed to 8.4.x, then cherry-picked to 8.3.x. Thanks!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Fixed » Needs work

I think this broke HEAD on postgres and sqlite - its the only thing that went into 8.3 and 8.4 recently, and given its touching the same test - figure it was the culprit https://www.drupal.org/node/3060/qa

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review

Let's re-test on those databases.

  • catch committed 9586b37 on 8.4.x 
    Revert "Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\...

  • catch committed e5721b0 on 8.3.x 
    Revert "Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\...
Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new 2891911-16.patch742 bytes
new interdiff-2-16.txt720 bytes

Good spot! Let's fix it.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new 2891911-17.patch741 bytes
new interdiff-16-17.txt729 bytes

с/c

catch’s picture

catch
he/him
Primary language English
commented

This interdiff 16/17 doesn't match the patch in 17?

xjm’s picture

xjm
she/her
Primary language English
commented 
+++ b/core/modules/locale/tests/src/Functional/LocaleTranslationUiTest.php
@@ -44,7 +44,7 @@ public function testStringTranslation() {
-    $name = 'name';
+    $name = 'сucurbitaceae';

Is this a botanical name? I don't recognize it. :)

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new interdiff-16-17-diff.txt729 bytes

#18: Hah! This is really not my interdiff). The size of my interdiff (769 bytes), but content has more size (4196 bytes). And it looks like one of version here #2876670-35: D8: Add error reporting when download fails/messes up. Reupload interdiff (replace cyrillic character, it appeared when I converted the word to lowercase).

#19: Yep) I wanted to apply something that went beyond the datebase terms. In the original I wanted to say "бахчевые" (a family of melons and watermelons). But I missed a bit with the translation and got on the family of pumpkin, that is close too.

Anonymous’s picture

Anonymous (not verified) commented

#18: Steps to reproduce this bug:

  1. Upload first file 'name.txt'. If file with such name already exists, then the current file will be renamed as 'name_0.txt'.
  2. Click 'Remove' without send the file.
  3. Upload second file with name 'name_0.txt'. View the contents of this file - it will be from the first file.
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

That sounds like a CDN or maybe varnish issue to me with #18.

Moving back to RTBC.

  • catch committed 14c2920 on 8.5.x 
    Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\Functional\...

  • catch committed f0f6935 on 8.4.x 
    Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\Functional\...

  • catch committed 5f0dfad on 8.3.x 
    Issue #2891911 by vaplas: Random fail in Drupal\Tests\locale\Functional\...
catch’s picture

catch
he/him
Primary language English
commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed/cherry-picked to all three 8.x branches, thanks!

tacituseu’s picture

tacituseu commented

Not that I think it is the reason, but things started segfaulting after this commit:
https://www.drupal.org/pift-ci-job/728146
https://www.drupal.org/pift-ci-job/728160
https://www.drupal.org/pift-ci-job/728179
https://www.drupal.org/pift-ci-job/728206

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.