[meta] Fix and re-enable tests skipped for random failures

Chromedriver is updated, so let's debug the tests skipped in:
#3267124: Temporarily skip failing tests
#3267823: \Drupal\Tests\quickedit\FunctionalJavascript\QuickEditIntegrationTest::testCustomBlock(). is failing on latest chromedriver

So of the five tests here, repeated 50x each:

• \Drupal\Tests\layout_builder\FunctionalJavascript\AjaxBlockTest
  passed 50 times
• \Drupal\Tests\layout_builder\FunctionalJavascript\ContentPreviewToggleTest
  passed 48 times, failed twice
• \Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderDisableInteractionsTest
  passed 50 times
• \Drupal\Tests\layout_builder\FunctionalJavascript\LayoutBuilderTest
  passed 50 times
• \Drupal\Tests\quickedit\FunctionalJavascript\QuickEditIntegrationTest
  failed 43 times, passed 7 times

ContentPreviewToggleTest has two different stack traces for the two fails:

1) Drupal\Tests\layout_builder\FunctionalJavascript\ContentPreviewToggleTest::testContentPreviewToggle
Behat\Mink\Exception\ElementHtmlException: Element exists on the page.

/var/www/html/core/modules/layout_builder/tests/src/FunctionalJavascript/ContentPreviewToggleTest.php:138
/var/www/html/core/modules/layout_builder/tests/src/FunctionalJavascript/ContentPreviewToggleTest.php:88

vs

1) Drupal\Tests\layout_builder\FunctionalJavascript\ContentPreviewToggleTest::testContentPreviewToggle
Behat\Mink\Exception\ElementHtmlException: Element exists on the page.

/var/www/html/core/modules/layout_builder/tests/src/FunctionalJavascript/ContentPreviewToggleTest.php:138
/var/www/html/core/modules/layout_builder/tests/src/FunctionalJavascript/ContentPreviewToggleTest.php:94

QuickEditIntegrationTest mostly fails with:

1) Drupal\Tests\quickedit\FunctionalJavascript\QuickEditIntegrationTest::testCustomBlock
Failed asserting that null is identical to 'Body'.

/var/www/html/core/modules/quickedit/tests/src/FunctionalJavascript/QuickEditJavascriptTestBase.php:179
/var/www/html/core/modules/quickedit/tests/src/FunctionalJavascript/QuickEditIntegrationTest.php:312

but once with

1) Drupal\Tests\quickedit\FunctionalJavascript\QuickEditIntegrationTest::testArticleNode
JavaScript condition met:
Drupal.quickedit.collections.entities.get('node/1[0]').get('state') === 'closed'
Failed asserting that false is true.

/var/www/html/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:158
/var/www/html/core/modules/quickedit/tests/src/FunctionalJavascript/QuickEditIntegrationTest.php:262

Let's try a few more runs of the passing ones to prove that they're passing.

The majority of QuickEditIntegrationTest fails might be something to do with the hover state; the field name is only shown in the toolbar when the pointer is hovering over the field itself; otherwise only the entity title is shown. I am not sure where the pointer is placed in tests by default, nor do I see anything that explicitly places the pointer in these tests.

Having said that, the test does not appear to use any random factors so the result should (in theory) be deterministic? Maybe this could be a race condition though, where the hover event does not always fire?

@longwave Yeah a good 75% or more of our random fails in JS functional tests historically are due to race conditions and not using the correct APIs to wait for elements to be rendered.

The other three are definitely still failing plenty:
https://dispatcher.drupalci.org/job/drupal_patches/117467/console

For the 400 total runs of each in #7:

• AjaxBlockTest had only a 5% fail rate
• LayoutBuilderDisableInteractionsTest had a 17% fail rate
• LayoutBuilderTest had an 8% fail rate

I also think the numbers in #5 are incorrect; there are a total of 43 failures and 2 errors in the results of #3. Sorry, read it the wrong way around.

Meanwhile: #3268070: Temporarily skip even more failing tests

Converting this to a meta.

Added #3268368: Robustify and restore \Drupal\Tests\ckeditor5\FunctionalJavascript\MediaLibraryTest::testButton to the IS.

Adding #3268678: [random test failure] Restore ContentPreviewToggleTest::testContentPreviewToggle().

Adding #3268680: [random test failure] Restore and fix LayoutBuilderDisableInteractionsTest::testFormsLinksDisabled().

#3268680: [random test failure] Restore and fix LayoutBuilderDisableInteractionsTest::testFormsLinksDisabled() is in, so we can use the mechanism added in that issue and see if it can be applied to other Layout Builder tests (or anything else that tests the off-canvas area).

Adding #3274053: [random test failure] Restore LayoutBuilderNestedFormUiTest::testAddingFormBlocksToDefaults() to the issue summary.

Adding additional skipped tests. Sorry, LB.

Tried to add #3351596: Skip Drupal\Tests\ckeditor5\FunctionalJavascript\MediaLibraryTest + #3351597: [random test failure] Drupal\Tests\ckeditor5\FunctionalJavascript\MediaLibraryTest to the summary, but it was unclear if the list at the top are the follow-up issues to un-skip things, or the original issues where we started skipping (it's some of both).

I added a remaining tasks to start to track which ones still need child issues to get them un-skipped and working.

Maybe it'd be more clear if we had separate lists:

1. Tests we've had to skip
2. Issues to fix + stop skipping them
3. Issues like #2 that are already fixed and the test is active again (the current "Already fixed" list)

? Not sure the best way to track this plan and all its issues... 😅

Thanks/sorry,
-Derek

Moved Already fixed issues to the Already fixed section.
(Life can be so easy sometimes...)