Problem/Motivation

See https://git.drupalcode.org/project/drupal/-/jobs/5012708

  CKEditor5Markup (Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5Markup)
     ✔ Attribute encoding
     ✔ Filter html allowed global attributes
     ✘ Comments
       ┐
       ├ Behat\Mink\Exception\ExpectationException: The string "This is a test!" was not found anywhere in the HTML response of the current page.
       │
       │ /builds/project/drupal/vendor/behat/mink/src/WebAssert.php:888
       │ /builds/project/drupal/vendor/behat/mink/src/WebAssert.php:363
       │ /builds/project/drupal/core/tests/Drupal/Tests/WebAssert.php:559
       │ /builds/project/drupal/core/modules/ckeditor5/tests/src/FunctionalJavascript/CKEditor5MarkupTest.php:194
       ┴
     ✔ Styles and scripts

Steps to reproduce

Baseline MR: https://git.drupalcode.org/project/drupal/-/merge_requests/14336
Repeat 250x: https://git.drupalcode.org/issue/drupal-3520036/-/jobs/7986314 (fail 1 / 250)

Proposed resolution

Fix MR: https://git.drupalcode.org/project/drupal/-/merge_requests/14338
Repeat 250x: https://git.drupalcode.org/issue/drupal-3520036/-/jobs/7986593 (pass 250 / 250)

Remaining tasks

  1. Verify test results on both MRs
  2. Reviews / refinements
  3. RTBC
  4. Commit / rejoince

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3520036

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Also occasionally seeing a different failure in the same test: https://git.drupalcode.org/issue/drupal-3559326/-/jobs/7415151

    CKEditor5Markup (Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5Markup)
     ✔ Attribute encoding
     ✔ Filter html allowed global attributes
     ✔ Comments
     ✘ Styles and scripts
       ┐
       ├ Behat\Mink\Exception\ExpectationException: The string "const example = 'Consider this string:

dww made their first commit to this issue’s fork.

dww opened merge request !14336

dww opened merge request !14338

dww’s picture

dww
we/he/they
commented
Issue summary: View changes
Status: Active » Needs work
Issue tags: +Bug Smash Initiative
dww’s picture

dww
we/he/they
commented
Issue summary: View changes
Status: Needs work » Needs review

Ready for review:

  • Baseline MR failed 1 / 250
  • Fix MR passed 250 / 250
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems similar to the other one where this assert fixed 250/250 and can't argue with those results

LGTM

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 1330fcc4535 to main and c4714979ae0 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • longwave committed c4714979 on 11.x 
    test: #3520036 [random test failure] CKEditor5MarkupTest

By: dww
(...

  • longwave committed 1330fcc4 on main 
    test: #3520036 [random test failure] CKEditor5MarkupTest

By: dww

longwave closed merge request !14336

longwave closed merge request !14338

  • longwave committed 5062f66f on 10.6.x 
    test: #3520036 [random test failure] CKEditor5MarkupTest

By: dww
(...

  • longwave committed a1496b2f on 11.3.x 
    test: #3520036 [random test failure] CKEditor5MarkupTest

By: dww
(...
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Backported to the release branches as well because it cherry-picks cleanly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.