In DrupalOAuthClient, line 44 (in 7.x-3.x-dev), we see the following param descriptor in the docblock:

  /* @param string $method
   *  Optional. The hmac hashing algorithm to use. Defaults to 'sha512' which
   *  has superseded sha1 as the recommended alternative.
   */

but in the actual function signature, we see this:

public static function signatureMethod($method = 'SHA1', $fallback_to_sha1 = TRUE) {

Since SHA1 is considered insecure, should the value of $method not be set to 'SHA512'?

CommentFileSizeAuthor
#2 oauth-2861262-2-signatureMethod.patch1.26 KBdaniel_j

Comments

daniel_j created an issue. See original summary.

daniel_j’s picture

StatusFileSize
new1.26 KB
daniel_j’s picture

Status: Active » Needs review
daniel_j’s picture

Bah, testbot is testing against 8.x, but patch is against 7.x.