Problem/Motivation

Annotation based plugins are deprecated, I don't think we need BC here since this was supported back in 10.2

Steps to reproduce

Try to use the module on core HEAD, get errors about missing field types

Proposed resolution

Replace annotations with attributes

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork redirect-3544741

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley opened merge request !163

acbramley’s picture

acbramley commented
Status: Active » Needs review

jopdebeeck made their first commit to this issue’s fork.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

Hello,

I've reviewed current MR and I can confirm that added attributes look good and local testing of changes also produced no results. Test are failing due to deprecations introduced in Drupals 11.3 release and this module issue queue already has an existing issue that covers these failing tests. Marking this as RTBC.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

Looks good, needs a rebase though.

I'd be fine to explicitly require 10.3 now and drop all BC except entity and migrate attributes, which is still quite a bit. still fewer future cleanup.

acbramley’s picture

acbramley commented
Status: Needs work » Reviewed & tested by the community

  • berdir committed 42965e72 on 8.x-1.x authored by acbramley 
    feat: #3544741 Convert redirect plugins to attributes

By: acbramley
By...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.