They show up but the only thing you can do with them is queue/dequeue, That's quite confusing and useless.
The local list should probably only include entity types/bundles that have the required field.
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | sharedcontent-1941798-17.patch | 21.4 KB | corvus_ch |
| #17 | sharedcontent-1941798-17.interdiff.txt | 4.03 KB | corvus_ch |
| #15 | sharedcontent-1941798-15.patch | 20.41 KB | corvus_ch |
| #13 | sharedcontent-1941798-13.patch | 20.36 KB | corvus_ch |
| #10 | sharedcontent-1941798-9.patch | 20.3 KB | corvus_ch |
Comments
Comment #1
miro_dietikerThis filter was once present. If it's no more, it needs to be readded ASAP.
I'm even thinking about considering this a major usability issue.
Comment #2
corvus_ch commentedThe filter was already present but got lost in the templete features. Here it is again.
Comment #3
corvus_ch commentedThis will be actually pretty save to commit for it only affects the template ans explicitly needs to be copied to the productive copy of the features.
Comment #4
miro_dietikerThis seems fine. However, test coverage missing and as it seems, important.
Comment #5
corvus_ch commentedWriting test is currently a big issue as described in #1958562: Add ctools access plugin to suggestions tab to enable ShareBoard testing. I suggest we get this patch in and provide the tests after we have found solution for the testing.
Comment #6
corvus_ch commentedWaiting for #1958562: Add ctools access plugin to suggestions tab to enable ShareBoard testing and then add tests.
Comment #7
corvus_ch commentedBack to work.
Comment #8
corvus_ch commentedCommitted what was present so far. Tests will follow.
Comment #9
corvus_ch commentedThe views query plugin did not work for both search_api_solr and search_api_db. I replaced the query plugin with a calculated attribute which then can be index with search api.
As of the notices thrown in
flag_get_content_flags()see #1351124: Notice: Undefined index: in flag_get_entity_flags() / flag_get_content_flags().Comment #10
corvus_ch commentedSorry missed the patch somehow.
Comment #11
corvus_ch commentedThis has become a blocker for #1955560: Add tests for missing check if active content exists.
Comment #13
corvus_ch commentedIt probably would help to have all dependencies.
Added search_api_db as test dependency.
Comment #15
corvus_ch commentedDefined dependency to get test ignored until we have updated dependencies.
Comment #16
berdirNice cleanup.
"Returns TRUE if the index is linkable"?
attribute => property
empty line between @param and @return.
Seems like directly creating the entity would be easier?
pattern-apply-machine! :)
sharedcontent_client_attach_shared_content_field($field_name, $entity_type, $bundle);?
kinkabke? Is that something to eat?
Comment #17
corvus_ch commentedDefinitive pattern apply machine ;)
Comment #18
berdirI guess this one here is the reason using the form api makes sense. This allows you to e.g. prevent an attempt to create two servers with the same name.
Comment #19
corvus_ch commentedCommitted & pushed without the change in the drush callback.