Problem/Motivation
There is a test failure in testTotpReplay:
fail: [Other] Line 275 of sites/all/modules/tfa_basic/tests/tfa_basic.test:
"My account" found
See: https://www.drupal.org/pift-ci-job/2717439
Steps to reproduce
Run tests.
Proposed resolution
Check and fix the failing test. The failure can be caused by fast tests execution when the REQUEST_TIME is still same as the $accepted_expiration. Check if adding a sleep(1) would help.
db_delete('tfa_accepted_code')
->condition('time_accepted', REQUEST_TIME - $accepted_expiration, '<')
->execute();
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3374884-2.patch | 416 bytes | poker10 |
Comments
Comment #2
poker10 commentedLet's check the testbot.
Comment #4
poker10 commented