Problem/Motivation

There is a test failure in testTotpReplay:

fail: [Other] Line 275 of sites/all/modules/tfa_basic/tests/tfa_basic.test:
"My account" found

See: https://www.drupal.org/pift-ci-job/2717439

Steps to reproduce

Run tests.

Proposed resolution

Check and fix the failing test. The failure can be caused by fast tests execution when the REQUEST_TIME is still same as the $accepted_expiration. Check if adding a sleep(1) would help.

db_delete('tfa_accepted_code')
    ->condition('time_accepted', REQUEST_TIME - $accepted_expiration, '<')
    ->execute();

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3374884-2.patch416 bytespoker10

Comments

poker10 created an issue. See original summary.

poker10’s picture

Status: Active » Needs review
StatusFileSize
new416 bytes

Let's check the testbot.

  • poker10 committed 3fa7576c on 7.x-1.x
    Issue #3374884 by poker10: testTotpReplay test failure
    
poker10’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.