| From: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
|---|---|
| To: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove unused rel parameter in lookup_var_attr_stats |
| Date: | 2025-01-03 15:42:01 |
| Message-ID: | CAFcNs+r7nJiONQEnS6fdzWKusVMJun+A-jKGm=PShidkku9OeA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 3, 2025 at 11:09 AM Ilia Evdokimov <
ilya(dot)evdokimov(at)tantorlabs(dot)com> wrote:
> Hi hackers,
>
> I've attached a small patch that remove unused parameter 'rel' from
> the static function lookup_var_attr_stats() in extended_stats.c
>
> While exploring src/backend/statistics, I noticed that there are several
> other parameters which appear to be unused. However, since the
> discussion around import/export statistics [1] attribute_stats.c is
> still ongoing and many functions from other files are non-static, those
> parameters may yet prove useful. Therefore, I'm only removing the
> parameter from this static function.
>
>
LGTM looks like a leftover from a4d75c86.
Regards,
--
Fabrízio de Royes Mello
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2025-01-03 15:44:15 | Re: [PATCH] Fix jsonb comparison for raw scalar pseudo arrays |
| Previous Message | Andres Freund | 2025-01-03 14:47:58 | Re: Autovacuum giving up on tables after crash because of lack of stats |