| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Added missing tab completion for alter subscription set option |
| Date: | 2021-05-15 09:33:45 |
| Message-ID: | CALj2ACWo8H7MsCbye5no8wThULKAWH0qtt3qaooPd80khfb7Kw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 15, 2021 at 10:44 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> I have added a commitfest entry at [1].
> Thanks for the comments, the attached patch has the changes for the same.
>
> [1] - https://commitfest.postgresql.org/33/3116/
Thanks Vignesh. The v3 patch looks good to me. It applies and compiles
well, works as expected i.e. the streaming and binary options are
shown in the tab-complete of the ALTER SUBSCRIPTION SET command. I
have no further comments, hence moving it to "ready for committer"
state.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2021-05-15 09:42:15 | Re: [Patch] ALTER SYSTEM READ ONLY |
| Previous Message | Bharath Rupireddy | 2021-05-15 09:28:10 | Re: alter subscription drop publication fixes |