pgsql: Fix canAcceptConnections() bugs introduced by replication-relate

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix canAcceptConnections() bugs introduced by replication-relate
Date: 2010-11-14 20:58:17
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix canAcceptConnections() bugs introduced by replication-related patches.

We must not return any "okay to proceed" result code without having checked
for too many children, else we might fail later on when trying to add the
new child to one of the per-child state arrays. It's not clear whether
this oversight explains Stefan Kaltenbrunner's recent report, but it could
certainly produce a similar symptom.

Back-patch to 8.4; the logic was not broken before that.

Branch
------
REL8_4_STABLE

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=6318fa0fdb1ad22b489f1f9f8018ffa70e2e724c

Modified Files
--------------
src/backend/postmaster/postmaster.c | 29 +++++++++++++++++------------
1 files changed, 17 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-11-15 02:09:22 Re: [COMMITTERS] pgsql: Improved parallel make support
Previous Message Tom Lane 2010-11-14 17:50:31 pgsql: Work around make 3.80 bug with long expansions of $(eval).