pgsql: Don't balance vacuum cost delay when per-table settings are in e

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't balance vacuum cost delay when per-table settings are in e
Date: 2014-10-03 16:04:34
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't balance vacuum cost delay when per-table settings are in effect

When there are cost-delay-related storage options set for a table,
trying to make that table participate in the autovacuum cost-limit
balancing algorithm produces undesirable results: instead of using the
configured values, the global values are always used,
as illustrated by Mark Kirkwood in
http://www.postgresql.org/message-id/[email protected]

Since the mechanism is already complicated, just disable it for those
cases rather than trying to make it cope. There are undesirable
side-effects from this too, namely that the total I/O impact on the
system will be higher whenever such tables are vacuumed. However, this
is seen as less harmful than slowing down vacuum, because that would
cause bloat to accumulate. Anyway, in the new system it is possible to
tweak options to get the precise behavior one wants, whereas with the
previous system one was simply hosed.

This has been broken forever, so backpatch to all supported branches.
This might affect systems where cost_limit and cost_delay have been set
for individual tables.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/06646f52ea43ba7ac7e89a2bc2e4493539e805e8

Modified Files
--------------
doc/src/sgml/maintenance.sgml | 9 ++++++---
src/backend/postmaster/autovacuum.c | 23 ++++++++++++++++++++---
2 files changed, 26 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-10-03 18:48:58 pgsql: Fix bogus logic for zic -P option.
Previous Message Robert Haas 2014-10-03 15:47:51 pgsql: Fix typos in comments.