pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte
Date: 2017-11-12 21:09:42
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext.

PostgreSQL running as a Windows service crashed upon calling
write_stderr() before MemoryContextInit(). This fix completes work
started in 5735efee15540765315aa8c1a230575e756037f7. Messages this
early contain only ASCII bytes; if we removed the CurrentMemoryContext
requirement, the ensuing conversions would have no effect. Back-patch
to 9.3 (all supported versions).

Takayuki Tsunakawa, reviewed by Michael Paquier.

Discussion: https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CC73@G01JPEXMBYT05

Branch
------
REL9_3_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/30e99efe82c71c0320983dee5a9789e9f3f8a8e3

Modified Files
--------------
src/backend/utils/error/elog.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Noah Misch 2017-11-12 22:31:59 pgsql: Install Windows crash dump handler before all else.
Previous Message Noah Misch 2017-11-11 22:54:13 pgsql: Add post-2010 ecpg tests to checktcp.