From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Re-allow INSERT .. ON CONFLICT DO NOTHING on partitioned tables. |
Date: | 2017-12-01 17:57:55 |
Message-ID: | [email protected] |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Re-allow INSERT .. ON CONFLICT DO NOTHING on partitioned tables.
Commit 8355a011a0124bdf7ccbada206a967d427039553 was reverted in
f05230752d53c4aa74cffa9b699983bbb6bcb118, but this attempt is
hopefully better-considered: we now pass the correct value to
ExecOpenIndices, which should avoid the crash that we hit before.
Amit Langote, reviewed by Simon Riggs and by me. Some final
editing by me.
Discussion: http://postgr.es/m/[email protected]
Branch
------
master
Modified Files
--------------
doc/src/sgml/ddl.sgml | 13 +++++++++----
src/backend/commands/copy.c | 3 ++-
src/backend/executor/execPartition.c | 15 ++++++++++-----
src/backend/executor/nodeModifyTable.c | 3 ++-
src/backend/parser/analyze.c | 8 --------
src/include/executor/execPartition.h | 3 ++-
src/test/regress/expected/insert_conflict.out | 13 +++++++++++++
src/test/regress/sql/insert_conflict.sql | 13 +++++++++++++
8 files changed, 51 insertions(+), 20 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-12-01 18:50:13 | pgsql: postgres_fdw: Fix test that didn't test what it claimed. |
Previous Message | Robert Haas | 2017-12-01 16:08:04 | pgsql: Try to exclude partitioned tables in toto. |