pgsql: When a TAP file has non-zero exit status, retain temporary direc

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: When a TAP file has non-zero exit status, retain temporary direc
Date: 2020-02-05 16:29:13
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

When a TAP file has non-zero exit status, retain temporary directories.

PostgresNode already retained base directories in such cases. Stop
using $SIG{__DIE__}, which is redundant with the exit status check, in
lieu of proliferating it to TestLib. Back-patch to 9.6, where commit
88802e068017bee8cea7a5502a712794e761c7b5 introduced retention on
failure.

Reviewed by Daniel Gustafsson.

Discussion: https://postgr.es/m/[email protected]

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/78a26c3edd85b439265c067c45f04ce017c2eaff

Modified Files
--------------
src/test/perl/PostgresNode.pm | 17 +----------------
src/test/perl/TestLib.pm | 9 +++++++--
2 files changed, 8 insertions(+), 18 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2020-02-05 17:22:59 Re: pgsql: Prevent running pg_basebackup as root
Previous Message Fujii Masao 2020-02-05 05:07:15 pgsql: Add note about how each partition's default value is treated, in