From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: jit: Correct parameter type for generated expression evaluation |
Date: | 2020-12-08 03:34:03 |
Message-ID: | [email protected] |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
jit: Correct parameter type for generated expression evaluation functions.
clang only uses the 'i1' type for scalar booleans, not for pointers to
booleans (as the pointer might be pointing into a larger memory
allocation). Therefore a pointer-to-bool needs to the "storage" boolean.
There's no known case of wrong code generation due to this, but it seems quite
possible that it could cause problems (see e.g. 72559438f92).
Author: Andres Freund
Discussion: https://postgr.es/m/[email protected]
Backpatch: 11-, where jit support was added
Branch
------
REL_13_STABLE
Modified Files
--------------
src/backend/jit/llvm/llvmjit_expr.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2020-12-08 03:34:08 | pgsql: jit: configure: Explicitly reference 'native' component. |
Previous Message | Michael Paquier | 2020-12-08 03:23:00 | pgsql: Avoid using tuple from syscache for update of pg_database.datfro |