| Lists: | pgsql-hackers |
|---|
| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | minor code question: portal memory cxts |
| Date: | 2004-10-11 23:29:31 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
The memory context created at src/backend/utils/mmgr/portalmem.c:183
shares the name of the memory context created at portalmem.c:279 (they
are both called "PortalHeapMemory"). Is there a reason for this?
-Neil
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: minor code question: portal memory cxts |
| Date: | 2004-10-11 23:40:02 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Neil Conway <neilc(at)samurai(dot)com> writes:
> The memory context created at src/backend/utils/mmgr/portalmem.c:183
> shares the name of the memory context created at portalmem.c:279 (they
> are both called "PortalHeapMemory"). Is there a reason for this?
Copy-and-paste oversight I'd say. Probably the latter ought to be
"PortalHoldContext" or some such.
regards, tom lane
| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: minor code question: portal memory cxts |
| Date: | 2004-10-12 01:50:32 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, 2004-10-12 at 09:40, Tom Lane wrote:
> Copy-and-paste oversight I'd say. Probably the latter ought to be
> "PortalHoldContext" or some such.
Thanks, that's what I suspected. I've applied the attached fix to HEAD.
-Neil
| Attachment | Content-Type | Size |
|---|---|---|
| portal-mem-cntx-name-1.patch | text/x-patch | 848 bytes |