Re: Bug of the hot standby feedback

Lists: pgsql-hackers
From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Bug of the hot standby feedback
Date: 2011-02-28 13:54:11
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-hackers

Hi,

When I implemented the replication timeout patch, I found the bug on
the HS feedback feature. When wal_receiver_status_interval is zero
and hot_standby_feedback is enabled, walreceiver sends the feedback
too aggressively. I think that the attached patch should be applied to
fix the bug.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
hot_standby_feedback_bug_v1.patch application/octet-stream 613 bytes

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Bug of the hot standby feedback
Date: 2011-03-01 16:34:59
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Feb 28, 2011 at 8:54 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> When I implemented the replication timeout patch, I found the bug on
> the HS feedback feature. When wal_receiver_status_interval is zero
> and hot_standby_feedback is enabled, walreceiver sends the feedback
> too aggressively. I think that the attached patch should be applied to
> fix the bug.

Committed, with some related documentation changes.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company