pgsql: Restructure the pg_upgrade code to use several global structures

Restructure the pg_upgrade code to use several global structures rather
than packing everything into 'ctx' and passing that to every function.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=e13f7e9a711c9117e438516537066bbe61df6455

Modified Files
--------------
contrib/pg_upgrade/check.c | 299 +++++++++++++++++-----------------
contrib/pg_upgrade/controldata.c | 182 ++++++++++----------
contrib/pg_upgrade/dump.c | 28 ++--
contrib/pg_upgrade/exec.c | 62 ++++----
contrib/pg_upgrade/file.c | 22 ++--
contrib/pg_upgrade/function.c | 94 ++++++------
contrib/pg_upgrade/info.c | 116 +++++++-------
contrib/pg_upgrade/option.c | 141 ++++++++--------
contrib/pg_upgrade/page.c | 26 ++--
contrib/pg_upgrade/pg_upgrade.c | 287 ++++++++++++++++----------------
contrib/pg_upgrade/pg_upgrade.h | 177 +++++++++++----------
contrib/pg_upgrade/relfilenode.c | 84 +++++-----
contrib/pg_upgrade/server.c | 114 ++++++-------
contrib/pg_upgrade/tablespace.c | 53 +++---
contrib/pg_upgrade/util.c | 76 +++++----
contrib/pg_upgrade/version.c | 25 ++--
contrib/pg_upgrade/version_old_8_3.c | 166 +++++++++----------
17 files changed, 976 insertions(+), 976 deletions(-)

On Wed, Oct 20, 2010 at 6:38 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Restructure the pg_upgrade code to use several global structures rather
> than packing everything into 'ctx' and passing that to every function.
> -------
> http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=e13f7e9a711c9117e438516537066bbe61df6455

I see the following warning message:
----
In file included from check.c:10:
pg_upgrade.h:243: warning: built-in function ‘log’ declared as non-function
----
gcc (GCC) 4.4.4 20100630 (Red Hat 4.4.4-10)

pg_upgrade.h has a variable 'log'.
extern Log log;

It might be platform-dependent, but I think we'd better rename it.

--
Itagaki Takahiro

Itagaki Takahiro wrote:
> On Wed, Oct 20, 2010 at 6:38 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Restructure the pg_upgrade code to use several global structures rather
> > than packing everything into 'ctx' and passing that to every function.
> > -------
> > http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=e13f7e9a711c9117e438516537066bbe61df6455
>
> I see the following warning message:
> ----
> In file included from check.c:10:
> pg_upgrade.h:243: warning: built-in function ?log? declared as non-function
> ----
> gcc (GCC) 4.4.4 20100630 (Red Hat 4.4.4-10)
>
> pg_upgrade.h has a variable 'log'.
> extern Log log;
>
> It might be platform-dependent, but I think we'd better rename it.

Thanks, done.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +