| Lists: | pgsql-committers |
|---|
| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: pg_upgrade: Fix exec_prog API to be less flaky |
| Date: | 2012-08-27 18:31:21 |
| Message-ID: | [email protected] |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-committers |
pg_upgrade: Fix exec_prog API to be less flaky
The previous signature made it very easy to pass something other than
the printf-format specifier in the corresponding position, without any
warning from the compiler.
While at it, move some of the escaping, redirecting and quoting
responsibilities from the callers into exec_prog() itself. This makes
the callsites cleaner.
Branch
------
master
Modified Files
--------------
contrib/pg_upgrade/check.c | 9 +---
contrib/pg_upgrade/dump.c | 9 ++--
contrib/pg_upgrade/exec.c | 80 ++++++++++++++++++++------------------
contrib/pg_upgrade/pg_upgrade.c | 68 +++++++++++++--------------------
contrib/pg_upgrade/pg_upgrade.h | 9 ++--
contrib/pg_upgrade/server.c | 34 ++++++++---------
6 files changed, 96 insertions(+), 113 deletions(-)