pgsql: Add missing period to detail message.

Lists: pgsql-committers
From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Add missing period to detail message.
Date: 2012-08-30 17:28:17
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

Add missing period to detail message.

Per note from Peter Eisentraut.

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/588fb3f01f7159990a9bfabb578615c3c32ffc6e

Modified Files
--------------
src/backend/storage/lmgr/proc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add missing period to detail message.
Date: 2012-08-30 18:08:21
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

On Thu, Aug 30, 2012 at 05:28:17PM +0000, Robert Haas wrote:
> Add missing period to detail message.
>
> Per note from Peter Eisentraut.
>
> Branch
> ------
> REL8_3_STABLE
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/588fb3f01f7159990a9bfabb578615c3c32ffc6e
>
> Modified Files
> --------------
> src/backend/storage/lmgr/proc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

I didn't think we backpatched error string changes because of
translation churn.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add missing period to detail message.
Date: 2012-08-30 19:02:28
Message-ID: CA+TgmoadUZQhCuWcL_tbBu8a8FNAvq6F=SDqH5nk7jRXJ7ZE0g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

On Thu, Aug 30, 2012 at 2:08 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Thu, Aug 30, 2012 at 05:28:17PM +0000, Robert Haas wrote:
>> Add missing period to detail message.
>>
>> Per note from Peter Eisentraut.
>>
>> Branch
>> ------
>> REL8_3_STABLE
>>
>> Details
>> -------
>> http://git.postgresql.org/pg/commitdiff/588fb3f01f7159990a9bfabb578615c3c32ffc6e
>>
>> Modified Files
>> --------------
>> src/backend/storage/lmgr/proc.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> I didn't think we backpatched error string changes because of
> translation churn.

Well, the patch that this was related to was back-patched, so I
figured this should be, too. That concern did cross my mind, though.
I can revert in the back branches if the translations team prefers.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add missing period to detail message.
Date: 2012-08-30 19:06:55
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

On Thu, Aug 30, 2012 at 03:02:28PM -0400, Robert Haas wrote:
> On Thu, Aug 30, 2012 at 2:08 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > On Thu, Aug 30, 2012 at 05:28:17PM +0000, Robert Haas wrote:
> >> Add missing period to detail message.
> >>
> >> Per note from Peter Eisentraut.
> >>
> >> Branch
> >> ------
> >> REL8_3_STABLE
> >>
> >> Details
> >> -------
> >> http://git.postgresql.org/pg/commitdiff/588fb3f01f7159990a9bfabb578615c3c32ffc6e
> >>
> >> Modified Files
> >> --------------
> >> src/backend/storage/lmgr/proc.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > I didn't think we backpatched error string changes because of
> > translation churn.
>
> Well, the patch that this was related to was back-patched, so I
> figured this should be, too. That concern did cross my mind, though.
> I can revert in the back branches if the translations team prefers.

Oh, if the patch was backpatched, the error message churn probably isn't
a problem then.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add missing period to detail message.
Date: 2012-08-30 19:30:15
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Thu, Aug 30, 2012 at 03:02:28PM -0400, Robert Haas wrote:
>> On Thu, Aug 30, 2012 at 2:08 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>>> I didn't think we backpatched error string changes because of
>>> translation churn.

>> Well, the patch that this was related to was back-patched, so I
>> figured this should be, too. That concern did cross my mind, though.
>> I can revert in the back branches if the translations team prefers.

> Oh, if the patch was backpatched, the error message churn probably isn't
> a problem then.

The message itself is new as of earlier this month, no? So likely
nobody has translated it yet anyway. Probably better to get it right
now.

regards, tom lane