pgsql: Ensure libpq reports a suitable error message on unexpected sock

Lists: pgsql-committers
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Ensure libpq reports a suitable error message on unexpected sock
Date: 2014-10-22 22:42:32
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

Ensure libpq reports a suitable error message on unexpected socket EOF.

The EOF-detection logic in pqReadData was a bit confused about who should
set up the error message in case the kernel gives us read-ready-but-no-data
rather than ECONNRESET or some other explicit error condition. Since the
whole point of this situation is that the lower-level functions don't know
there's anything wrong, pqReadData itself must set up the message. But
keep the assumption that if an errno was reported, a message was set up at
lower levels.

Per bug #11712 from Marko Tiikkaja. It's been like this for a very long
time, so back-patch to all supported branches.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/ac6e8753707337d338e3a5fdb99d4f593ebc2df5

Modified Files
--------------
src/interfaces/libpq/fe-misc.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)