pgsql: New C function: bms_add_range

New C function: bms_add_range

This will be used by pending patches to improve partition pruning.

Amit Langote and Kyotaro Horiguchi, per a suggestion from David
Rowley. Review and testing of the larger patch set of which this is a
part by Ashutosh Bapat, David Rowley, Dilip Kumar, Jesper Pedersen,
Rajkumar Raghuwanshi, Beena Emerson, Amul Sul, and Kyotaro Horiguchi.

Discussion: http://postgr.es/m/[email protected]

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/84940644de931f331433b35e3a391822671f8c9c

Modified Files
--------------
src/backend/nodes/bitmapset.c | 72 +++++++++++++++++++++++++++++++++++++++++++
src/include/nodes/bitmapset.h | 1 +
2 files changed, 73 insertions(+)

On 2017/11/30 7:12, Robert Haas wrote:
> New C function: bms_add_range
>
> This will be used by pending patches to improve partition pruning.
>
> Amit Langote and Kyotaro Horiguchi, per a suggestion from David
> Rowley. Review and testing of the larger patch set of which this is a
> part by Ashutosh Bapat, David Rowley, Dilip Kumar, Jesper Pedersen,
> Rajkumar Raghuwanshi, Beena Emerson, Amul Sul, and Kyotaro Horiguchi.
>
> Discussion: http://postgr.es/m/[email protected]

Thanks for committing this.

To be accurate, as also noted in the commit message of the patch that I
sent, authors of this patch are David Rowley and Kyotaro Horiguchi. David
came up with the idea and the patch first [1], which Horiguchi-san later
commented on to improve the code. My job has simply been to incorporate
their patch in the bigger patch set.

Thanks,
Amit

[1]
https://www.postgresql.org/message-id/CAKJS1f88-EOpbicP6QuT2Omq00om8j_1XtkyheuimP336DG-gw%40mail.gmail.com

[2]
https://www.postgresql.org/message-id/20171110.123000.151902771.horiguchi.kyotaro%40lab.ntt.co.jp

On Wed, Nov 29, 2017 at 8:27 PM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> To be accurate, as also noted in the commit message of the patch that I
> sent, authors of this patch are David Rowley and Kyotaro Horiguchi. David
> came up with the idea and the patch first [1], which Horiguchi-san later
> commented on to improve the code. My job has simply been to incorporate
> their patch in the bigger patch set.

Crap, I apologize. I looked at the commit message you wrote in
putting together mine, but I somehow blanked out the fact that you had
listed David rather than yourself as first author. That was bad of
me, and I am sorry.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 30 November 2017 at 14:48, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Nov 29, 2017 at 8:27 PM, Amit Langote
> <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> To be accurate, as also noted in the commit message of the patch that I
>> sent, authors of this patch are David Rowley and Kyotaro Horiguchi. David
>> came up with the idea and the patch first [1], which Horiguchi-san later
>> commented on to improve the code. My job has simply been to incorporate
>> their patch in the bigger patch set.
>
> Crap, I apologize. I looked at the commit message you wrote in
> putting together mine, but I somehow blanked out the fact that you had
> listed David rather than yourself as first author. That was bad of
> me, and I am sorry.

Unfortunate, but you're forgiven :-p

I've attached a small patch to fix the comment at the head of the
function. I thought I had fixed this, but seems I didn't.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

On Thu, Nov 30, 2017 at 3:53 PM, David Rowley
<david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> Unfortunate, but you're forgiven :-p
>
> I've attached a small patch to fix the comment at the head of the
> function. I thought I had fixed this, but seems I didn't.

Thanks, committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company