pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().

Lists: pgsql-committers
From: Jeff Davis <jdavis(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
Date: 2025-06-10 18:24:26
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

inet_net_pton.c: use pg_ascii_tolower() rather than tolower().

Avoid dependence on setlocale(). No behavior change.

Discussion: https://postgr.es/m/[email protected]
Reviewed-by: Peter Eisentraut <peter(at)eisentraut(dot)org>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8898082a5d3e94eef073f0e08124137e096e78ef

Modified Files
--------------
src/backend/utils/adt/inet_net_pton.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
Date: 2025-06-10 19:49:35
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

On Tue, 2025-06-10 at 18:24 +0000, Jeff Davis wrote:
> inet_net_pton.c: use pg_ascii_tolower() rather than tolower().

These 4 small patches were somewhat of a "false start" on 19 -- sorry
about that. Not sure if it's worth it to revert them and reapply in a
couple weeks, as they look pretty harmless.

Regards,
Jeff Davis

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
Date: 2025-06-10 20:31:50
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> On Tue, 2025-06-10 at 18:24 +0000, Jeff Davis wrote:
>> inet_net_pton.c: use pg_ascii_tolower() rather than tolower().

> These 4 small patches were somewhat of a "false start" on 19 -- sorry
> about that. Not sure if it's worth it to revert them and reapply in a
> couple weeks, as they look pretty harmless.

Ask the RMT, I guess. I don't have any objection, but they
have final say at this stage.

regards, tom lane

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Jeff Davis <jdavis(at)postgresql(dot)org>
Subject: Re: pgsql: inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
Date: 2025-06-10 20:56:53
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers

On 10 June 2025 13:31:50 GMT-07:00, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>Jeff Davis <pgsql(at)j-davis(dot)com> writes:
>> On Tue, 2025-06-10 at 18:24 +0000, Jeff Davis wrote:
>>> inet_net_pton.c: use pg_ascii_tolower() rather than tolower().
>
>> These 4 small patches were somewhat of a "false start" on 19 -- sorry
>> about that. Not sure if it's worth it to revert them and reapply in a
>> couple weeks, as they look pretty harmless.
>
>Ask the RMT, I guess. I don't have any objection, but they
>have final say at this stage.

Seems fine by me to include it in v18.

- Heikki