Mismatch in libpqwalreceiver

Lists: pgsql-hackers
From: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Mismatch in libpqwalreceiver
Date: 2010-03-23 16:49:34
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-hackers

There's a mismatch in HEAD between README and the actual definition in
replication/libpqwalreceiver.

In README,

bool walrcv_receive(int timeout, XLogRecPtr *recptr, char **buffer, int *len)

but in walreceiver.h,

typedef bool (*walrcv_receive_type) (int timeout, unsigned char *type,
char **buffer, int *len);

It seems this commit forgot README fix.

http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walreceiver.h?r1=1.5&r2=1.6

Regards,

--
Hitoshi Harada

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Mismatch in libpqwalreceiver
Date: 2010-03-24 01:02:27
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Mar 24, 2010 at 1:49 AM, Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> wrote:
> There's a mismatch in HEAD between README and the actual definition in
> replication/libpqwalreceiver.
>
> In README,
>
> bool walrcv_receive(int timeout, XLogRecPtr *recptr, char **buffer, int *len)
>
> but in walreceiver.h,
>
> typedef bool (*walrcv_receive_type) (int timeout, unsigned char *type,
>                                                                                                 char **buffer, int *len);
>
>
> It seems this commit forgot README fix.
>
> http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walreceiver.h?r1=1.5&r2=1.6

Thanks for the report! That is my mistake. Here is the patch.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
walreceiver_readme_v1.patch application/octet-stream 638 bytes
From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Mismatch in libpqwalreceiver
Date: 2010-03-24 06:26:44
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-hackers

Fujii Masao wrote:
> On Wed, Mar 24, 2010 at 1:49 AM, Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> wrote:
>> It seems this commit forgot README fix.
>>
>> http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/replication/walreceiver.h?r1=1.5&r2=1.6
>
> Thanks for the report!

Yep, thanks. Applied, and I also added description of the returned values.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com