[email protected] | f3d3b38 | 2014-03-14 21:19:28 | [diff] [blame] | 1 | // Copyright 2014 The Chromium Authors. All rights reserved. |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
[email protected] | f3d3b38 | 2014-03-14 21:19:28 | [diff] [blame] | 5 | #include "chrome/browser/extensions/pending_extension_manager.h" |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 6 | |
[email protected] | d31e19e | 2012-08-22 00:19:04 | [diff] [blame] | 7 | #include <algorithm> |
| 8 | |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 9 | #include "base/logging.h" |
[email protected] | e398785 | 2012-05-04 10:06:30 | [diff] [blame] | 10 | #include "base/version.h" |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame] | 11 | #include "chrome/common/extensions/extension_constants.h" |
[email protected] | c38831a1 | 2011-10-28 12:44:49 | [diff] [blame] | 12 | #include "content/public/browser/browser_thread.h" |
[email protected] | 46f3e10 | 2014-03-25 01:22:45 | [diff] [blame] | 13 | #include "extensions/browser/extension_prefs.h" |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame] | 14 | #include "extensions/browser/extension_registry.h" |
hanxi | a3182da | 2014-09-02 22:51:19 | [diff] [blame] | 15 | #include "extensions/common/constants.h" |
[email protected] | b52f8ca | 2013-11-28 08:25:22 | [diff] [blame] | 16 | #include "extensions/common/extension.h" |
[email protected] | a6483d2 | 2013-07-03 22:11:00 | [diff] [blame] | 17 | #include "url/gurl.h" |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 18 | |
[email protected] | 631bb74 | 2011-11-02 11:29:39 | [diff] [blame] | 19 | using content::BrowserThread; |
| 20 | |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 21 | namespace { |
| 22 | |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 23 | // Install predicate used by AddFromExternalUpdateUrl(). |
[email protected] | 8f3bcbd | 2013-06-05 08:42:40 | [diff] [blame] | 24 | bool AlwaysInstall(const extensions::Extension* extension) { |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 25 | return true; |
| 26 | } |
| 27 | |
thakis | 37be69c | 2015-08-19 03:26:57 | [diff] [blame] | 28 | std::string GetVersionString(const Version& version) { |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 29 | return version.IsValid() ? version.GetString() : "invalid"; |
| 30 | } |
| 31 | |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 32 | } // namespace |
| 33 | |
[email protected] | 3f213ad | 2012-07-26 23:39:41 | [diff] [blame] | 34 | namespace extensions { |
| 35 | |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 36 | PendingExtensionManager::PendingExtensionManager( |
[email protected] | 46f3e10 | 2014-03-25 01:22:45 | [diff] [blame] | 37 | content::BrowserContext* context) |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame] | 38 | : context_(context) {} |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 39 | |
| 40 | PendingExtensionManager::~PendingExtensionManager() {} |
| 41 | |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 42 | const PendingExtensionInfo* PendingExtensionManager::GetById( |
| 43 | const std::string& id) const { |
| 44 | PendingExtensionList::const_iterator iter; |
| 45 | for (iter = pending_extension_list_.begin(); |
| 46 | iter != pending_extension_list_.end(); |
| 47 | ++iter) { |
| 48 | if (id == iter->id()) |
| 49 | return &(*iter); |
| 50 | } |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 51 | |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 52 | return NULL; |
| 53 | } |
| 54 | |
| 55 | bool PendingExtensionManager::Remove(const std::string& id) { |
| 56 | PendingExtensionList::iterator iter; |
| 57 | for (iter = pending_extension_list_.begin(); |
| 58 | iter != pending_extension_list_.end(); |
| 59 | ++iter) { |
| 60 | if (id == iter->id()) { |
| 61 | pending_extension_list_.erase(iter); |
| 62 | return true; |
| 63 | } |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 64 | } |
| 65 | |
| 66 | return false; |
| 67 | } |
| 68 | |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 69 | bool PendingExtensionManager::IsIdPending(const std::string& id) const { |
[email protected] | 870f557 | 2013-12-19 12:30:15 | [diff] [blame] | 70 | return GetById(id) != NULL; |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 71 | } |
| 72 | |
[email protected] | 9bd9a686 | 2012-11-29 09:24:22 | [diff] [blame] | 73 | bool PendingExtensionManager::HasPendingExtensions() const { |
| 74 | return !pending_extension_list_.empty(); |
| 75 | } |
| 76 | |
[email protected] | d31e19e | 2012-08-22 00:19:04 | [diff] [blame] | 77 | bool PendingExtensionManager::HasPendingExtensionFromSync() const { |
| 78 | PendingExtensionList::const_iterator iter; |
| 79 | for (iter = pending_extension_list_.begin(); |
| 80 | iter != pending_extension_list_.end(); |
| 81 | ++iter) { |
| 82 | if (iter->is_from_sync()) |
| 83 | return true; |
| 84 | } |
| 85 | |
| 86 | return false; |
| 87 | } |
| 88 | |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 89 | bool PendingExtensionManager::AddFromSync( |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 90 | const std::string& id, |
| 91 | const GURL& update_url, |
treib | e960e28 | 2015-09-11 10:38:08 | [diff] [blame] | 92 | const base::Version& version, |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 93 | PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install, |
mamir | 192d788 | 2016-06-22 17:10:16 | [diff] [blame^] | 94 | bool remote_install) { |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 95 | CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
| 96 | |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame] | 97 | if (ExtensionRegistry::Get(context_)->GetExtensionById( |
| 98 | id, ExtensionRegistry::EVERYTHING)) { |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 99 | LOG(ERROR) << "Trying to add pending extension " << id |
| 100 | << " which already exists"; |
| 101 | return false; |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 102 | } |
| 103 | |
[email protected] | b873cd9 | 2012-02-09 21:51:48 | [diff] [blame] | 104 | // Make sure we don't ever try to install the CWS app, because even though |
| 105 | // it is listed as a syncable app (because its values need to be synced) it |
| 106 | // should already be installed on every instance. |
hanxi | a3182da | 2014-09-02 22:51:19 | [diff] [blame] | 107 | if (id == extensions::kWebStoreAppId) { |
[email protected] | b873cd9 | 2012-02-09 21:51:48 | [diff] [blame] | 108 | NOTREACHED(); |
| 109 | return false; |
| 110 | } |
| 111 | |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame] | 112 | static const bool kIsFromSync = true; |
| 113 | static const Manifest::Location kSyncLocation = Manifest::INTERNAL; |
| 114 | static const bool kMarkAcknowledged = false; |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 115 | |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 116 | return AddExtensionImpl(id, |
| 117 | std::string(), |
| 118 | update_url, |
treib | e960e28 | 2015-09-11 10:38:08 | [diff] [blame] | 119 | version, |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 120 | should_allow_install, |
| 121 | kIsFromSync, |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 122 | kSyncLocation, |
[email protected] | 21db9ef | 2014-05-16 02:06:27 | [diff] [blame] | 123 | kMarkAcknowledged, |
| 124 | remote_install); |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 125 | } |
| 126 | |
[email protected] | 9f4e4f08 | 2013-06-21 07:11:19 | [diff] [blame] | 127 | bool PendingExtensionManager::AddFromExtensionImport( |
| 128 | const std::string& id, |
| 129 | const GURL& update_url, |
| 130 | PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install) { |
| 131 | CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
| 132 | |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame] | 133 | if (ExtensionRegistry::Get(context_)->GetExtensionById( |
| 134 | id, ExtensionRegistry::EVERYTHING)) { |
[email protected] | 9f4e4f08 | 2013-06-21 07:11:19 | [diff] [blame] | 135 | LOG(ERROR) << "Trying to add pending extension " << id |
| 136 | << " which already exists"; |
| 137 | return false; |
| 138 | } |
| 139 | |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame] | 140 | static const bool kIsFromSync = false; |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame] | 141 | static const Manifest::Location kManifestLocation = Manifest::INTERNAL; |
| 142 | static const bool kMarkAcknowledged = false; |
| 143 | static const bool kRemoteInstall = false; |
[email protected] | 9f4e4f08 | 2013-06-21 07:11:19 | [diff] [blame] | 144 | |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 145 | return AddExtensionImpl(id, |
| 146 | std::string(), |
| 147 | update_url, |
thakis | 37be69c | 2015-08-19 03:26:57 | [diff] [blame] | 148 | Version(), |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 149 | should_allow_install, |
| 150 | kIsFromSync, |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 151 | kManifestLocation, |
[email protected] | 21db9ef | 2014-05-16 02:06:27 | [diff] [blame] | 152 | kMarkAcknowledged, |
| 153 | kRemoteInstall); |
[email protected] | 9f4e4f08 | 2013-06-21 07:11:19 | [diff] [blame] | 154 | } |
| 155 | |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 156 | bool PendingExtensionManager::AddFromExternalUpdateUrl( |
[email protected] | 612a1cb1 | 2012-10-17 13:18:03 | [diff] [blame] | 157 | const std::string& id, |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 158 | const std::string& install_parameter, |
[email protected] | 612a1cb1 | 2012-10-17 13:18:03 | [diff] [blame] | 159 | const GURL& update_url, |
[email protected] | 464213a | 2013-10-15 01:06:48 | [diff] [blame] | 160 | Manifest::Location location, |
| 161 | int creation_flags, |
| 162 | bool mark_acknowledged) { |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 163 | CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
| 164 | |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame] | 165 | static const bool kIsFromSync = false; |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame] | 166 | static const bool kRemoteInstall = false; |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 167 | |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame] | 168 | const Extension* extension = ExtensionRegistry::Get(context_) |
| 169 | ->GetExtensionById(id, ExtensionRegistry::EVERYTHING); |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 170 | if (extension && location == Manifest::GetHigherPriorityLocation( |
| 171 | location, extension->location())) { |
[email protected] | 8a87a533 | 2011-08-11 17:54:59 | [diff] [blame] | 172 | // If the new location has higher priority than the location of an existing |
| 173 | // extension, let the update process overwrite the existing extension. |
| 174 | } else { |
[email protected] | 46f3e10 | 2014-03-25 01:22:45 | [diff] [blame] | 175 | if (ExtensionPrefs::Get(context_)->IsExternalExtensionUninstalled(id)) |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 176 | return false; |
| 177 | |
[email protected] | 8a87a533 | 2011-08-11 17:54:59 | [diff] [blame] | 178 | if (extension) { |
| 179 | LOG(DFATAL) << "Trying to add extension " << id |
| 180 | << " by external update, but it is already installed."; |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 181 | return false; |
[email protected] | 8a87a533 | 2011-08-11 17:54:59 | [diff] [blame] | 182 | } |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 183 | } |
| 184 | |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 185 | return AddExtensionImpl(id, |
| 186 | install_parameter, |
| 187 | update_url, |
thakis | 37be69c | 2015-08-19 03:26:57 | [diff] [blame] | 188 | Version(), |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 189 | &AlwaysInstall, |
| 190 | kIsFromSync, |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 191 | location, |
[email protected] | 21db9ef | 2014-05-16 02:06:27 | [diff] [blame] | 192 | mark_acknowledged, |
| 193 | kRemoteInstall); |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 194 | } |
| 195 | |
thakis | 37be69c | 2015-08-19 03:26:57 | [diff] [blame] | 196 | |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 197 | bool PendingExtensionManager::AddFromExternalFile( |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 198 | const std::string& id, |
[email protected] | 1d5e58b | 2013-01-31 08:41:40 | [diff] [blame] | 199 | Manifest::Location install_source, |
thakis | 37be69c | 2015-08-19 03:26:57 | [diff] [blame] | 200 | const Version& version, |
[email protected] | 464213a | 2013-10-15 01:06:48 | [diff] [blame] | 201 | int creation_flags, |
| 202 | bool mark_acknowledged) { |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 203 | // TODO(skerner): AddFromSync() checks to see if the extension is |
| 204 | // installed, but this method assumes that the caller already |
| 205 | // made sure it is not installed. Make all AddFrom*() methods |
| 206 | // consistent. |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame] | 207 | const GURL& kUpdateUrl = GURL::EmptyGURL(); |
| 208 | static const bool kIsFromSync = false; |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame] | 209 | static const bool kRemoteInstall = false; |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 210 | |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 211 | return AddExtensionImpl(id, |
| 212 | std::string(), |
| 213 | kUpdateUrl, |
| 214 | version, |
| 215 | &AlwaysInstall, |
| 216 | kIsFromSync, |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 217 | install_source, |
[email protected] | 21db9ef | 2014-05-16 02:06:27 | [diff] [blame] | 218 | mark_acknowledged, |
| 219 | kRemoteInstall); |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 220 | } |
| 221 | |
| 222 | void PendingExtensionManager::GetPendingIdsForUpdateCheck( |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 223 | std::list<std::string>* out_ids_for_update_check) const { |
| 224 | PendingExtensionList::const_iterator iter; |
| 225 | for (iter = pending_extension_list_.begin(); |
| 226 | iter != pending_extension_list_.end(); |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 227 | ++iter) { |
[email protected] | 1d5e58b | 2013-01-31 08:41:40 | [diff] [blame] | 228 | Manifest::Location install_source = iter->install_source(); |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 229 | |
| 230 | // Some install sources read a CRX from the filesystem. They can |
| 231 | // not be fetched from an update URL, so don't include them in the |
| 232 | // set of ids. |
[email protected] | 1d5e58b | 2013-01-31 08:41:40 | [diff] [blame] | 233 | if (install_source == Manifest::EXTERNAL_PREF || |
binjin | 52eb4041 | 2015-08-18 06:29:30 | [diff] [blame] | 234 | install_source == Manifest::EXTERNAL_REGISTRY || |
| 235 | install_source == Manifest::EXTERNAL_POLICY) { |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 236 | continue; |
binjin | 52eb4041 | 2015-08-18 06:29:30 | [diff] [blame] | 237 | } |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 238 | |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 239 | out_ids_for_update_check->push_back(iter->id()); |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 240 | } |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 241 | } |
| 242 | |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 243 | bool PendingExtensionManager::AddExtensionImpl( |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 244 | const std::string& id, |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 245 | const std::string& install_parameter, |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 246 | const GURL& update_url, |
thakis | 37be69c | 2015-08-19 03:26:57 | [diff] [blame] | 247 | const Version& version, |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 248 | PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install, |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 249 | bool is_from_sync, |
[email protected] | 464213a | 2013-10-15 01:06:48 | [diff] [blame] | 250 | Manifest::Location install_source, |
[email protected] | 21db9ef | 2014-05-16 02:06:27 | [diff] [blame] | 251 | bool mark_acknowledged, |
| 252 | bool remote_install) { |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 253 | CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
| 254 | |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 255 | PendingExtensionInfo info(id, |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 256 | install_parameter, |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 257 | update_url, |
| 258 | version, |
| 259 | should_allow_install, |
| 260 | is_from_sync, |
[email protected] | 464213a | 2013-10-15 01:06:48 | [diff] [blame] | 261 | install_source, |
[email protected] | 21db9ef | 2014-05-16 02:06:27 | [diff] [blame] | 262 | mark_acknowledged, |
| 263 | remote_install); |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 264 | |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 265 | if (const PendingExtensionInfo* pending = GetById(id)) { |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 266 | // Bugs in this code will manifest as sporadic incorrect extension |
| 267 | // locations in situations where multiple install sources run at the |
| 268 | // same time. For example, on first login to a chrome os machine, an |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 269 | // extension may be requested by sync and the default extension set. |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 270 | // The following logging will help diagnose such issues. |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 271 | VLOG(1) << "Extension id " << id |
| 272 | << " was entered for update more than once." |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 273 | << " old location: " << pending->install_source() |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 274 | << " new location: " << install_source |
| 275 | << " old version: " << GetVersionString(pending->version()) |
| 276 | << " new version: " << GetVersionString(version); |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 277 | |
[email protected] | e398785 | 2012-05-04 10:06:30 | [diff] [blame] | 278 | // Never override an existing extension with an older version. Only |
| 279 | // extensions from local CRX files have a known version; extensions from an |
| 280 | // update URL will get the latest version. |
[email protected] | e398785 | 2012-05-04 10:06:30 | [diff] [blame] | 281 | |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 282 | // If |pending| has the same or higher precedence than |info| then don't |
| 283 | // install |info| over |pending|. |
| 284 | if (pending->CompareTo(info) >= 0) |
[email protected] | e398785 | 2012-05-04 10:06:30 | [diff] [blame] | 285 | return false; |
[email protected] | e398785 | 2012-05-04 10:06:30 | [diff] [blame] | 286 | |
| 287 | VLOG(1) << "Overwrite existing record."; |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 288 | |
| 289 | std::replace(pending_extension_list_.begin(), |
| 290 | pending_extension_list_.end(), |
| 291 | *pending, |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 292 | info); |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 293 | } else { |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 294 | pending_extension_list_.push_back(info); |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 295 | } |
| 296 | |
[email protected] | e398785 | 2012-05-04 10:06:30 | [diff] [blame] | 297 | return true; |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 298 | } |
| 299 | |
| 300 | void PendingExtensionManager::AddForTesting( |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 301 | const PendingExtensionInfo& pending_extension_info) { |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 302 | pending_extension_list_.push_back(pending_extension_info); |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 303 | } |
[email protected] | 3f213ad | 2012-07-26 23:39:41 | [diff] [blame] | 304 | |
| 305 | } // namespace extensions |