eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 1 | # Chrome Network Bug Triage : Components and labels |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 2 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 3 | ## Some network component caveats |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 4 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 5 | **UI>Browser>Downloads** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 6 | : Despite the name, this covers all issues related to downloading a file except |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 7 | saving entire pages (which is **Blink>SavePage**), not just UI issues. |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 8 | Most downloads bugs will have the word "download" or "save as" in the |
| 9 | description. Issues with the HTTP server for the Chrome binaries are not |
| 10 | downloads bugs. |
| 11 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 12 | **UI>Browser>SafeBrowsing** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 13 | : Bugs that have to do with the process by which a URL or file is determined to |
| 14 | be dangerous based on our databases, or the resulting interstitials. |
| 15 | Determination of danger based purely on content-type or file extension |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 16 | belongs in **UI>Browser>Downloads**, not SafeBrowsing. |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 17 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 18 | **Internals>Network>SSL** |
| 19 | : This includes issues that should be also tagged as **Security>UX** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 20 | (certificate error pages or other security interstitials, omnibox indicators |
| 21 | that a page is secure), and more general SSL issues. If you see requests |
| 22 | that die in the SSL negotiation phase, in particular, this is often the |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 23 | correct component. |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 24 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 25 | **Internals>Network>DataProxy** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 26 | : Flywheel / the Data Reduction Proxy. Issues require "Reduce Data Usage" be |
| 27 | turned on. Proxy url is [https://proxy.googlezip.net:443](), with |
| 28 | [http://compress.googlezip.net:80]() as a fallback. Currently Android and |
| 29 | iOS only. |
| 30 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 31 | **Internals>Network>Cache** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 32 | : The cache is the layer that handles most range request logic (Though range |
| 33 | requests may also be issued by the PDF plugin, XHRs, or other components). |
| 34 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 35 | **Internals>Network>SPDY** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 36 | : Covers HTTP2 as well. |
| 37 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 38 | **Internals>Network>HTTP** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 39 | : Typically not used. Unclear what it covers, and there's no specific HTTP |
| 40 | owner. |
| 41 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 42 | **Internals>Network>Logging** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 43 | : Covers **about:net-internals**, **about:net-export** as well as the what's |
| 44 | sent to the NetLog. |
| 45 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 46 | **Internals>Network>Connectivity** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 47 | : Issues related to switching between networks, ERR_NETWORK_CHANGED, Chrome |
| 48 | thinking it's online when it's not / navigator.onLine inaccuracies, etc. |
| 49 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 50 | **Internals>Network>Filters** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 51 | : Covers SDCH and gzip issues. ERR_CONTENT_DECODING_FAILED indicates a problem |
| 52 | at this layer, and bugs here can also cause response body corruption. |
| 53 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 54 | ## Common non-network components |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 55 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 56 | Bugs in these areas often receive the **Internals>Network** component, though |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 57 | they fall largely outside the purview of the network stack team: |
| 58 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 59 | **Blink>Forms** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 60 | : Issues submitting forms, forms having weird data, forms sending the wrong |
| 61 | method, etc. |
| 62 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 63 | **Blink>Loader** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 64 | : Cross origin issues are sometimes loader related. Blink also has an |
| 65 | in-memory cache, and when it's used, requests don't appear in |
| 66 | about:net-internals. Requests for the same URL are also often merged there |
| 67 | as well. This does *not* cover issues with content/browser/loader/ files. |
| 68 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 69 | **Blink>ServiceWorker** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 70 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 71 | **Blink>Storage>AppCache** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 72 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 73 | **Blink>Network>WebSockets** |
| 74 | : Issues with the WebSockets. Attach this component to any issue about the |
tyoshino | c1ece4b | 2015-12-01 10:52:52 | [diff] [blame] | 75 | WebSocket feature regardless of where the cause of the issue is (net/ or |
| 76 | Blink). |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 77 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 78 | **Blink>Network>FetchAPI** |
tyoshino | c1ece4b | 2015-12-01 10:52:52 | [diff] [blame] | 79 | : Generic issues with the Fetch API - missing request or response |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 80 | headers, multiple headers, etc. These will often run into issues in certain |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 81 | corner cases (Cross origin / CORS, proxy, whatever). Attach all components that |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 82 | seem appropriate. |
| 83 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 84 | **Blink>Network>XHR** |
tyoshino | c1ece4b | 2015-12-01 10:52:52 | [diff] [blame] | 85 | : Generic issues with sync/async XHR requests. |
| 86 | |
davidben | 62a1c86a | 2016-05-05 18:33:51 | [diff] [blame^] | 87 | **Blink>WebRTC>Network** |
| 88 | : Anything WebRTC-related does not use the net stack and should go here. |
| 89 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 90 | **Services>Sync** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 91 | : Sharing data/tabs/history/passwords/etc between machines not working. |
| 92 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 93 | **Services>Chromoting** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 94 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 95 | **Platform>Extensions** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 96 | : Issues extensions loading / not loading / hanging. |
| 97 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 98 | **Platform>Extensions>API** |
| 99 | : Issues with network related extension APIs should have this component. |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 100 | chrome.webRequest is the big one, I believe, but there are others. |
| 101 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 102 | **Internals>Plugins>Pepper[>SDK]** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 103 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 104 | **UI>Browser>Omnibox** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 105 | : Basically any issue with the omnibox. URLs being treated as search queries |
| 106 | rather than navigations, dropdown results being weird, not handling certain |
| 107 | unicode characters, etc. If the issue is new TLDs not being recognized by |
| 108 | the omnibox, that's due to Chrome's TLD list being out of date, and not an |
| 109 | omnibox issue. Such TLD issues should be duped against |
| 110 | http://crbug.com/37436. |
| 111 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 112 | **Internals>Media>Network** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 113 | : Issues related to media. These often run into the 6 requests per hostname |
| 114 | issue, and also have fun interactions with the cache, particularly in the |
| 115 | range request case. |
| 116 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 117 | **Internals>Plugins>PDF** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 118 | : Issues loading pdf files. These are often related to range requests, which |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 119 | also have some logic at the Internals>Network>Cache layer. |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 120 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 121 | **UI>Browser>Navigation** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 122 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 123 | **UI>Browser>History** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 124 | : Issues which only appear with forward/back navigation. |
| 125 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 126 | **OS>Systems>Network** / **OS>Systems>Mobile** / **OS>Systems>Bluetooth** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 127 | : These should be used for issues with ChromeOS's platform network code, and |
| 128 | not net/ issues on ChromeOS. |
| 129 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 130 | **Blink>SecurityFeature** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 131 | : CORS / Cross origin issues. Main frame cross-origin navigation issues are |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 132 | often actually **UI>Browser>Navigation** issues. |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 133 | |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 134 | **Privacy** |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 135 | : Privacy related bug (History, cookies discoverable by an entity that |
| 136 | shouldn't be able to do so, incognito state being saved in memory or on disk |
| 137 | beyond the lifetime of incognito tabs, etc). Generally used in conjunction |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 138 | with other components. |
| 139 | |
| 140 | ## Common labels |
asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame] | 141 | |
| 142 | **Type-Bug-Security** |
| 143 | : Security related bug (Allows for code execution from remote site, allows |
eroman | 9621195 | 2016-02-22 21:42:03 | [diff] [blame] | 144 | crossing security boundaries, unchecked array bounds, etc) should be tagged |
| 145 | with this label. |