Test fixes for 0.4.1 release. - #550
Merged
Merged
Conversation
- Commented tests that failed with release config. - Changed so merge builds build with release config so this doesn't burn us next release. - Added `swift --version` to Makefile so we can see what we're running up in CI.
madrob
reviewed
Aug 28, 2025
| } | ||
|
|
||
| @Test func stageReferenceResolution() throws { | ||
| //@Test |
Contributor
There was a problem hiding this comment.
I think using Test(.disabled) is preferred.
Contributor
Author
There was a problem hiding this comment.
TIL! Fixing.
@Test(.disabled())
madrob
reviewed
Aug 28, 2025
| .PHONY: build | ||
| build: | ||
| @echo Building container binaries... | ||
| @$(SWIFT) --version |
Contributor
There was a problem hiding this comment.
Do you want this on every build or only if CI=true?
Contributor
Author
There was a problem hiding this comment.
It's fine on every build - most developers won't even notice it on their local builds but it'll be there if they want a quick check
egernst
approved these changes
Aug 28, 2025
dcantah
pushed a commit
to apple/containerization
that referenced
this pull request
Sep 11, 2025
With the changes in this PR, we'll print the Swift version before building. This mirrors a similar change in container, introduced in apple/container#550.
mayooot
pushed a commit
to mayooot/containerization
that referenced
this pull request
Sep 12, 2025
With the changes in this PR, we'll print the Swift version before building. This mirrors a similar change in container, introduced in apple/container#550.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swift --versionto Makefile so we can see what we're running up in CI.