Skip to content

Conversation

@bhapas
Copy link
Contributor

@bhapas bhapas commented Oct 26, 2023

Proposed commit message

Add system tests for aws-s3 input in amazon_security_lake integration by using terraform service deployer and using the SQS queue_url generated in terraform outputs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Run elastic-package stack up -d -v && elastic-package test system -v

Related issues

@bhapas bhapas force-pushed the amazon_security_lake_system_tests branch from 50b0f85 to d1680da Compare October 26, 2023 11:48
@elasticmachine
Copy link

elasticmachine commented Oct 26, 2023

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-09T11:20:24.300+0000

  • Duration: 11 min 45 sec

Steps errors 4

Expand to view the steps failures

Check integration: amazon_security_lake
  • Took 0 min 1 sec . View more details here
  • Description: ../../build/elastic-package check -v
Take down the Elastic stack
  • Took 0 min 0 sec . View more details here
  • Description: build/elastic-package stack down -v
Google Storage Download
  • Took 0 min 0 sec . View more details here
Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@bhapas bhapas force-pushed the amazon_security_lake_system_tests branch from d1680da to f3bacb3 Compare October 26, 2023 11:52
@elasticmachine
Copy link

elasticmachine commented Oct 26, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 70.588% (12/17) 👎 -29.412
Classes 70.588% (12/17) 👎 -29.412
Methods 57.471% (50/87) 👎 -39.897
Lines 39.967% (3842/9613) 👎 -55.46
Conditionals 100.0% (0/0) 💚

@bhapas bhapas force-pushed the amazon_security_lake_system_tests branch 3 times, most recently from 656fabb to 9b20701 Compare October 30, 2023 07:25
@bhapas bhapas force-pushed the amazon_security_lake_system_tests branch from 9b20701 to 43c1855 Compare October 30, 2023 11:18
@andrewkroh
Copy link
Member

Checkout #7887 (comment). I think security lake uses a custom notification format to SQS instead of letting S3 write the event to SQS.

@bhapas bhapas force-pushed the amazon_security_lake_system_tests branch from feb4069 to e657aaa Compare November 1, 2023 13:06
@bhapas bhapas force-pushed the amazon_security_lake_system_tests branch from e657aaa to 91bcc9b Compare November 2, 2023 10:46
@bhapas
Copy link
Contributor Author

bhapas commented Nov 9, 2023

Depends on elastic/package-spec#662

@mrodm
Copy link
Collaborator

mrodm commented Dec 21, 2023

Hi @bhapas, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

@bhapas bhapas force-pushed the amazon_security_lake_system_tests branch 2 times, most recently from 82beefa to 065d5e3 Compare January 2, 2024 14:11
@bhapas bhapas force-pushed the amazon_security_lake_system_tests branch from 065d5e3 to bc23a4a Compare January 2, 2024 14:34
@narph narph added Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] and removed Team:Security-External Integrations labels Jan 29, 2024
@botelastic
Copy link

botelastic bot commented Feb 28, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Feb 28, 2024
@botelastic
Copy link

botelastic bot commented Mar 29, 2024

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stalled Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants