Skip to content

Conversation

@bhapas
Copy link
Contributor

@bhapas bhapas commented Nov 9, 2023

What does this PR do?

parquet files are only allowed for amazon_security_lake and to test the integration these files are to be allowed as S3 objects and hence allow them in files for terraform deployer.

Checklist

Related issues

@bhapas bhapas requested a review from a team as a code owner November 9, 2023 11:54
@bhapas bhapas force-pushed the add_parquet branch 2 times, most recently from e1920b5 to de14922 Compare November 9, 2023 12:09
contentMediaType: "application/json"
pattern: '^*.json$'
required: false
- description: Parquet files to add into terraform resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these parquet files? Could you provide an example in a test package on how it would be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a file format that is used by Amazon Security Lake and I have added an example file in the test package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But where is this file used? In terraform resources? Could you add an example about how the file would be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a special format used by Amazon Security Lake and this is just another S3 Object. I added an example terraform resource for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the test binary file in parquet format.

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM by now, let's keep an eye in case we need to add something more generic to allow any kind of file.

@bhapas bhapas requested a review from jsoriano November 9, 2023 17:04
@jsoriano jsoriano merged commit 3d820b7 into elastic:main Nov 9, 2023
@bhapas bhapas deleted the add_parquet branch November 9, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants