-
Notifications
You must be signed in to change notification settings - Fork 88
Allow parquet files in terraform service deployer #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e1920b5 to
de14922
Compare
| contentMediaType: "application/json" | ||
| pattern: '^*.json$' | ||
| required: false | ||
| - description: Parquet files to add into terraform resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these parquet files? Could you provide an example in a test package on how it would be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a file format that is used by Amazon Security Lake and I have added an example file in the test package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But where is this file used? In terraform resources? Could you add an example about how the file would be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a special format used by Amazon Security Lake and this is just another S3 Object. I added an example terraform resource for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the test binary file in parquet format.
💚 Build Succeeded
History
|
jsoriano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM by now, let's keep an eye in case we need to add something more generic to allow any kind of file.
What does this PR do?
parquetfiles are only allowed foramazon_security_lakeand to test the integration these files are to be allowed as S3 objects and hence allow them infilesfor terraform deployer.Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues