[ObsUX][Infra][APM] Hide Settings from serverless navigation #225436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
miloszmarcinkowski
approved these changes
Jun 26, 2025
Contributor
miloszmarcinkowski
left a comment
There was a problem hiding this comment.
Tested locally and looks good!
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Historycc @rmyz |
Contributor
|
Starting backport for target branches: 8.19 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
rmyz
added a commit
to rmyz/kibana
that referenced
this pull request
Jun 26, 2025
…#225436) ## Summary Closes [elastic#222240](elastic#222240) This PR adds the prop `sideNavStatus: 'hidden'` to the settings links to prevent them from appearing in the nav bar, but keeping them in the breadcrumbs. It also fixes the `Application` breadcrumb not being clickable. ## Screenshots | Description | Before | After | |--------|--------|--------| | Classic Infra |  |  | | Classic APM |  | | | Serverless Infra |  |  | | Serverless APM |  |  | (cherry picked from commit 76642fb) # Conflicts: # x-pack/solutions/observability/plugins/serverless_observability/public/navigation_tree.ts
meghanmurphy1
pushed a commit
to meghanmurphy1/kibana
that referenced
this pull request
Jun 26, 2025
…#225436) ## Summary Closes [elastic#222240](elastic#222240) This PR adds the prop `sideNavStatus: 'hidden'` to the settings links to prevent them from appearing in the nav bar, but keeping them in the breadcrumbs. It also fixes the `Application` breadcrumb not being clickable. ## Screenshots | Description | Before | After | |--------|--------|--------| | Classic Infra |  |  | | Classic APM |  | | | Serverless Infra |  |  | | Serverless APM |  |  |
meghanmurphy1
added a commit
to meghanmurphy1/kibana
that referenced
this pull request
Jun 26, 2025
…lastic#225436)" This reverts commit 6b04142.
rmyz
added a commit
that referenced
this pull request
Jun 26, 2025
…225436) (#225458) # Backport This will backport the following commits from `main` to `8.19`: - [[ObsUX][Infra][APM] Hide Settings from serverless navigation (#225436)](#225436) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-26T13:40:05Z","message":"[ObsUX][Infra][APM] Hide Settings from serverless navigation (#225436)\n\n## Summary\n\nCloses [#222240](https://github.com/elastic/kibana/issues/222240)\n\nThis PR adds the prop `sideNavStatus: 'hidden'` to the settings links to\nprevent them from appearing in the nav bar, but keeping them in the\nbreadcrumbs.\nIt also fixes the `Application` breadcrumb not being clickable.\n\n## Screenshots\n\n| Description | Before | After |\n|--------|--------|--------|\n| Classic Infra |\n\n|\n\n|\n| Classic APM |\n\n|\n|\n| Serverless Infra |\n\n|\n\n|\n| Serverless APM |\n\n|\n\n|","sha":"76642fbf16ef8ea9af5096103c45cc94265ec6fd","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[ObsUX][Infra][APM] Hide Settings from serverless navigation","number":225436,"url":"https://github.com/elastic/kibana/pull/225436","mergeCommit":{"message":"[ObsUX][Infra][APM] Hide Settings from serverless navigation (#225436)\n\n## Summary\n\nCloses [#222240](https://github.com/elastic/kibana/issues/222240)\n\nThis PR adds the prop `sideNavStatus: 'hidden'` to the settings links to\nprevent them from appearing in the nav bar, but keeping them in the\nbreadcrumbs.\nIt also fixes the `Application` breadcrumb not being clickable.\n\n## Screenshots\n\n| Description | Before | After |\n|--------|--------|--------|\n| Classic Infra |\n\n|\n\n|\n| Classic APM |\n\n|\n|\n| Serverless Infra |\n\n|\n\n|\n| Serverless APM |\n\n|\n\n|","sha":"76642fbf16ef8ea9af5096103c45cc94265ec6fd"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/225436","number":225436,"mergeCommit":{"message":"[ObsUX][Infra][APM] Hide Settings from serverless navigation (#225436)\n\n## Summary\n\nCloses [#222240](https://github.com/elastic/kibana/issues/222240)\n\nThis PR adds the prop `sideNavStatus: 'hidden'` to the settings links to\nprevent them from appearing in the nav bar, but keeping them in the\nbreadcrumbs.\nIt also fixes the `Application` breadcrumb not being clickable.\n\n## Screenshots\n\n| Description | Before | After |\n|--------|--------|--------|\n| Classic Infra |\n\n|\n\n|\n| Classic APM |\n\n|\n|\n| Serverless Infra |\n\n|\n\n|\n| Serverless APM |\n\n|\n\n|","sha":"76642fbf16ef8ea9af5096103c45cc94265ec6fd"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #222240
This PR adds the prop
sideNavStatus: 'hidden'to the settings links to prevent them from appearing in the nav bar, but keeping them in the breadcrumbs.It also fixes the
Applicationbreadcrumb not being clickable.Screenshots