Skip to content

[8.19] [ObsUX][Infra][APM] Hide Settings from serverless navigation (#225436) #225458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rmyz merged 1 commit into from
Jun 26, 2025
Merged

[8.19] [ObsUX][Infra][APM] Hide Settings from serverless navigation (#225436) #225458

rmyz merged 1 commit into from
Jun 26, 2025

Conversation

@rmyz
Copy link
Contributor

@rmyz rmyz commented Jun 26, 2025

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

@rmyz
[ObsUX][Infra][APM] Hide Settings from serverless navigation (elastic…
d7b188c 
…#225436)

## Summary

Closes [elastic#222240](elastic#222240)

This PR adds the prop `sideNavStatus: 'hidden'` to the settings links to
prevent them from appearing in the nav bar, but keeping them in the
breadcrumbs.
It also fixes the `Application` breadcrumb not being clickable.

## Screenshots

| Description | Before | After |
|--------|--------|--------|
| Classic Infra |
![image](https://github.com/user-attachments/assets/3b179b0b-cdca-4bc1-a4be-beffe689dbd1)
|
![image](https://github.com/user-attachments/assets/79a3cf5d-e7af-42eb-aa22-361f6f3f7527)
|
| Classic APM |
![image](https://github.com/user-attachments/assets/4944000a-e583-47c9-8647-7152b9eab60d)
|![image](https://github.com/user-attachments/assets/ab88c54c-8d5c-47fc-b46f-efc197da6673)
|
| Serverless Infra |
![image](https://github.com/user-attachments/assets/eece25d8-be06-457a-a4c8-940ce5f02790)
|
![image](https://github.com/user-attachments/assets/ca2b0d57-f0b3-4517-807e-a91e42e507bb)
|
| Serverless APM |
![image](https://github.com/user-attachments/assets/228bedba-7687-42cd-b47a-557bfbfda210)
|
![image](https://github.com/user-attachments/assets/7c7f551f-3d6a-4dcf-8ac3-167f0db0d05e)
|

(cherry picked from commit 76642fb)

# Conflicts:
#	x-pack/solutions/observability/plugins/serverless_observability/public/navigation_tree.ts
@rmyz rmyz requested a review from kibanamachine as a code owner June 26, 2025 13:49
@rmyz rmyz added the backport This PR is a backport of another PR label Jun 26, 2025
@rmyz rmyz enabled auto-merge (squash) June 26, 2025 13:49
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Jun 26, 2025
@rmyz rmyz mentioned this pull request Jun 26, 2025
Merged
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 26, 2025

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 26, 2025 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: d7b188c
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-225458-d7b188cc6672

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #6 / aiops log rate analysis in cases attaches log rate analysis to a case

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.3MB 1.3MB +10.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
serverlessObservability 42.4KB 42.5KB +56.0B

History

@rmyz rmyz merged commit d8f07b5 into elastic:8.19 Jun 26, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jennypavlova jennypavlova jennypavlova approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees

No one assigned

Labels

backport This PR is a backport of another PR ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rmyz @elasticmachine @jennypavlova