#9254 Add parametric image parsing to template viewer#9260
Merged
Conversation
5 tasks
Member
|
From our meeting with @MV88 to provide this functionality, I suggested to use the current image tool, improving it at least, instead of introducing the support to markdown inside wyiswyg that may be a problem for future maintainance of the functionality. |
offtherailz
requested changes
Jul 3, 2023
Member
There was a problem hiding this comment.
- Please remove the mixed markdown support and so the new image tool. Use the image tool present in react wysiwyg (replacing react quill)
- Check for backward compatibility with existing templates created with react quill ( I tried and it seems to work on demo map)
Contributor
Author
done both @offtherailz please review it again |
offtherailz
requested changes
Jul 5, 2023
Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
….jsx Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
Co-authored-by: Lorenzo Natali <lorenzo.natali@geosolutionsgroup.com>
MV88
commented
Jul 5, 2023
offtherailz
approved these changes
Jul 5, 2023
Contributor
Author
|
@ElenaGallo please test it in DEV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added possibility to insert image url in markdown
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9254
What is the new behavior?
react-draft-wysiwygBreaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
@tdipisa if we add a layer in gs-stable this would be easier for the tester
