Repository navigation
FIX: Prevent memory leak in RawArray by removing data from _init_kwargs - #14360
Merged
Merged
Conversation
adi-coderr
requested review from
agramfort,
drammock and
larsoner
as code owners
September 30, 2026 08:28
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
larsoner
approved these changes
Oct 1, 2026
larsoner
left a comment
Member
There was a problem hiding this comment.
I think this should work, thanks @adi-coderr
larsoner
enabled auto-merge (squash)
October 1, 2026 14:00
larsoner
disabled auto-merge
October 1, 2026 15:10
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Oct 1, 2026
* upstream/main: (26 commits) Splitting _brain.py into multiple modules (phase 1) (mne-tools#14359) Fix small corner-case bug with moments (mne-tools#14364) Coregistration GUI modernisation (phase 5) (mne-tools#14353) FIX: Prevent memory leak in RawArray by removing data from _init_kwargs (mne-tools#14360) MAINT: Update code credit (mne-tools#14365) type-hint the rest of mne/_fiff (mne-tools#14352) MAINT: Update dependency specifiers (mne-tools#14362) MAINT: Update dependency specifiers (mne-tools#14357) Switch to mne-tools SPEC-0 action (mne-tools#14356) MAINT: Move Pixi file updates to autofix workflow (mne-tools#14345) BUG: Fix SNIRF landmark length unit scaling (mne-tools#14354) DRY dipole code and comment on implementation (mne-tools#14350) Speed up CSD and PSD computations (mne-tools#14355) [dependabot]: Bump the actions group with 4 updates (mne-tools#14349) MAINT: Update pre-commit hook versions (mne-tools#14347) Switch to `mne-tools/rename-towncrier` action (mne-tools#14344) Fix for latest pyvista-js (mne-tools#14343) Avoid copies and support larger files in EEGLAB export (mne-tools#14338) Remove line breaks in sponsors check issue text (mne-tools#14337) Fix EEGLAB events after dropped epochs (mne-tools#14067) ... # Conflicts: # mne/viz/_brain/_brain.py # mne/viz/backends/tests/test_renderer.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes: #14074
Description of the problem
BaseRaw.__init__captures constructor arguments inself._init_kwargsvia_get_argvalues(). ForRawArray, this includes the complete signal array (self._init_kwargs["data"]).When operations such as
resample()orcrop()replaceraw._data,self._init_kwargs["data"]continues to hold a strong reference to the original array, preventing it from being garbage collected. In addition,raw.copy()deep-copies_init_kwargs, duplicating the unused dead array and multiplying memory usage.Solution
"data"fromself._init_kwargsinRawArray.__init__immediately aftersuper().__init__(...)._test_raw_reader(RawArray, ...)intest_array.pyto passtest_kwargs=False(since in-memoryRawArrayobjects cannot be re-instantiated without data like disk-based readers).weakrefregression check intest_array_copy()ensuringraw._datareplacement allows the original array to be collected and that"data"is absent from_init_kwargs.Assistance Disclosure
In accordance with the MNE AI-assistance policy in CONTRIBUTING.md, an AI coding assistant was used to help trace the frame inspection in
_get_argvalues()and draft the regression test.