Repository navigation
Switch order to prevent double-replacement in the query - #38783
Merged
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
IljaN
self-requested a review
May 27, 2021 08:17
Member
Author
|
Linking with #38649 since it's a bug fix for that PR. No need for changelog because target PR hasn't been released yet and this one is a follow up of the other. |
2 of 11 tasks
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The path used in the replacement for the path_hash column was the "new" one already replaced in the previous "set" clause. This was causing problems since the replacement could also happen in that new path, and could generate a wrong md5.
Switching the order makes sure the path used in the replace for both the path and path_hash columns will be the same
Related Issue
owncloud/encryption#276
Motivation and Context
How Has This Been Tested?
Manually tested using
occ files:transfer-ownershipocc files:transfer-ownershp user1 user2Previously, due to the wrong hash, a duplicate of the transfer file was generated in the DB, which was visible in the user2 account. This duplicate was causing side effects
This PR fixes that. The behaviour is the expected one.
Screenshots (if appropriate):
Types of changes
Checklist: